From: Greg KH <gregkh@us.ibm.com>
To: "Gérard Roudier" <groudier@free.fr>
Cc: Hanna Linder <hannal@us.ibm.com>,
greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: PCI Cleanup
Date: Thu, 22 Aug 2002 08:42:13 -0700 [thread overview]
Message-ID: <20020822154213.GB30158@us.ibm.com> (raw)
In-Reply-To: <20020822115025.B2502-100000@localhost.my.domain>
On Thu, Aug 22, 2002 at 12:11:41PM +0200, Gérard Roudier wrote:
>
>
> On Wed, 21 Aug 2002, Hanna Linder wrote:
>
> > Here is the first part of the sh port of the pci_ops
> > changes. If anyone can compile this for Sega let me
> > know if there are any problems.
>
> The 'val' pointer is declared 'u32 *', then casted 'u8 *' or 'u16 *' if
> needed. The compiler will not warn you. But user that wants to operate on
> u8 or u16 has to cast the 'val' argument to 'u32 *' and should get a
> warning from any decent C compiler. The normal C-way for such
> 'sorry-typed' argument is 'void *val', IMO.
We are filling up a u32 here (see the previous patches), so leaving this
as a u32 * and casting for the other sizes makes sense in this
situation.
thanks,
greg k-h
next prev parent reply other threads:[~2002-08-22 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-22 0:59 PCI Cleanup Hanna Linder
2002-08-22 3:10 ` Greg KH
2002-08-22 10:11 ` Gérard Roudier
2002-08-22 15:42 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-08-22 23:54 Hanna Linder
2002-08-21 22:14 Hanna Linder
2002-08-20 17:58 Hanna Linder
2002-08-20 18:00 ` David Mosberger
2002-08-20 18:30 ` Hanna Linder
2002-08-20 18:44 ` David Mosberger
2002-08-20 22:14 ` Hanna Linder
2002-08-20 22:13 ` David Mosberger
2002-08-20 22:45 ` Hanna Linder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020822154213.GB30158@us.ibm.com \
--to=gregkh@us.ibm.com \
--cc=greg@kroah.com \
--cc=groudier@free.fr \
--cc=hannal@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox