public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Pete Zaitcev <zaitcev@redhat.com>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	jsimmons@infradead.org
Subject: Re: Little console problem in 2.5.30
Date: Sat, 24 Aug 2002 00:57:56 -0400	[thread overview]
Message-ID: <20020824005756.A14783@devserv.devel.redhat.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0208191433430.23654-100000@vervain.sonytel.be>; from geert@linux-m68k.org on Mon, Aug 19, 2002 at 02:36:25PM +0200

> Date: Mon, 19 Aug 2002 14:36:25 +0200 (MEST)
> From: Geert Uytterhoeven <geert@linux-m68k.org>

> > I would appreciate if someone would explain me if the attached patch
> > does the right thing. The problem is that I do not use the framebuffer,
> > and use a serial console. Whenever a legacy /sbin/init tries to
> > open /dev/tty0, the system oopses dereferencing conswitchp in
> > visual_init().

> >  int vc_allocate(unsigned int currcons)	/* return 0 on success */
> >  {
> > -	if (currcons >= MAX_NR_CONSOLES)
> > +	if (currcons >= MAX_NR_CONSOLES || conswitchp == NULL)
> 
> And this worked before?
> 
> conswitchp must never be NULL, say `conswitchp = &dummy_con;' in your setup.c
> if you have a serial console.
> 
> >From looking at arch/sparc/kernel/setup.c, perhaps you have
> CONFIG_DUMMY_CONSOLE=n?

This only works if CONFIG_FB is present, and I do not want to add
one more useless chunk of code to the build. All my boxes have
serial consoles (like I said, I would throw CONFIG_VT away if
only it was not welded into the rest of the code so well).

-- Pete

  parent reply	other threads:[~2002-08-24  4:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-19  6:37 Little console problem in 2.5.30 Pete Zaitcev
2002-08-19 12:36 ` Geert Uytterhoeven
2002-08-20  1:25   ` Petr Vandrovec
2002-08-24  4:57   ` Pete Zaitcev [this message]
2002-08-24  4:49     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020824005756.A14783@devserv.devel.redhat.com \
    --to=zaitcev@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox