From: Jakub Jelinek <jakub@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Daniel Jacobowitz <dan@debian.org>,
junkio@cox.net, linux-kernel@vger.kernel.org,
Keith Owens <kaos@ocs.com.au>,
geert@linux-m68k.org, schwidefsky@de.ibm.com,
torvalds@transmeta.com
Subject: Re: [TRIVIAL] strlen("literal string") -> (sizeof("literal string")-1)
Date: Thu, 29 Aug 2002 03:10:08 -0400 [thread overview]
Message-ID: <20020829031008.T7920@devserv.devel.redhat.com> (raw)
In-Reply-To: <20020829015407.7DFCE2C0D9@lists.samba.org>; from rusty@rustcorp.com.au on Thu, Aug 29, 2002 at 04:29:04PM +1000
On Thu, Aug 29, 2002 at 04:29:04PM +1000, Rusty Russell wrote:
> In message <20020829032642.GA9201@nevyn.them.org> you write:
> > Also disagree; besides, the evidence implies that Keith is wrong. GCC
> > 2.95.3:
>
> i386, m68k, s390 and s390x define inline strlen() versions, so they
> are don't optimize strlen("literal").
>
> This premature optimization should probably be fixed,
Well, IMHO at least for the more recent GCC versions kernel
should leave the job to GCC (ie. either just prototype str* functions,
or define them to __builtin_str* variants).
Jakub
next prev parent reply other threads:[~2002-08-29 7:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.iks3ohv.1flge08@ifi.uio.no>
2002-08-28 21:31 ` [TRIVIAL] strlen("literal string") -> (sizeof("literal string")-1) junkio
2002-08-28 21:55 ` Jim Treadway
2002-08-29 3:09 ` Rusty Russell
2002-08-29 3:26 ` Daniel Jacobowitz
2002-08-29 6:29 ` Rusty Russell
2002-08-29 7:10 ` Jakub Jelinek [this message]
2002-08-29 16:56 ` Linus Torvalds
2002-08-29 20:38 ` Denis Zaitsev
2002-09-06 12:53 ` Pavel Machek
[not found] <fa.lrmcokv.1q28k2s@ifi.uio.no>
[not found] ` <fa.pm2g4iv.k0s9jg@ifi.uio.no>
2002-08-29 0:49 ` junio
2002-08-29 3:15 ` Rusty Russell
2002-08-29 15:39 ` Thunder from the hill
2002-08-29 15:48 ` Dave Jones
2002-08-30 3:50 ` Rusty Russell
[not found] <20020829031008.T7920@devserv.devel.redhat.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.44.0208290955280.2070-100000@home.transmeta.com.suse.lists.linux.kernel>
2002-08-29 17:23 ` Andi Kleen
2002-08-29 17:51 ` Alexander Viro
2002-08-29 17:53 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020829031008.T7920@devserv.devel.redhat.com \
--to=jakub@redhat.com \
--cc=dan@debian.org \
--cc=geert@linux-m68k.org \
--cc=junkio@cox.net \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox