Re: [patch 2.5.31] transparent PCI-to-PCI bridges

Ivan Kokshaysky
2002-08-28T01:35:49Z

On Mon, Aug 26, 2002 at 10:12:24PM +0200, Benjamin Herrenschmidt wrote:
> While we are at it, I still think the loop copying parent resource
> pointers in the case of a transparent bridge should copy the 4
> resource pointers of the parent and not only 3.

I agree that hardcoding the resource numbers is bad.
Instead, I suggest the following:
s/bus->resource[0]/bus->io/
s/bus->resource[1]/bus->mem/
s/bus->resource[2]/bus->pref_mem/
s/bus->resource[3]//

There are only 3 _bus_ resources - the PCI works this way.

Please don't propose your arch specific hacks to generic code.

Ivan.