Re: [patch] USB storage: Datafab KECF-USB, Sagatek DCS-CF

[Andries Brouwer <aebr@win.tue.nl>]

On Mon, Sep 02, 2002 at 08:41:13AM +0200, Marek Michalkiewicz wrote:
> > Am Don, 2002-08-29 um 15.57 schrieb Marek Michalkiewicz:
> > > > > UNUSUAL_DEV(  0x07c4, 0xa400, 0x0000, 0xffff,
> > > > > 		"Datafab",
> > > > > 		"KECF-USB",
> > > > > 		US_SC_SCSI, US_PR_BULK, NULL,
> > > > > 		US_FL_FIX_INQUIRY ),
> > 
> > This works fine with 2.4.20 - congratulations!!
> > I wonder what happened to the SCSI inquiry - was it limited to 36 bytes?
> 
> My understanding is that US_FL_FIX_INQUIRY flag fakes a response
> without sending the SCSI inquiry to the device at all.
> 
> What revision number does your device have, so we can limit the range
> (mine is 0113)?  How about US_FL_MODE_XLATE and US_FL_START_STOP -
> how to test if these flags are necessary?

I wrote in my unusual_devices.h source:

/* Marek Michalkiewicz - needed at least for revisions 0015 and 0113 */
UNUSUAL_DEV(  0x07c4, 0xa400, 0x0000, 0xffff,
              "Datafab",
              "KECF-USB",
              US_SC_SCSI, US_PR_BULK, NULL,
              US_FL_FIX_INQUIRY ),

and

/* aeb - needed at least for revision 0100 */
UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff,
                "Feiya",
                "5-in-1 Card Reader",
                US_SC_SCSI, US_PR_BULK, NULL,
                US_FL_FIX_CAPACITY ),

If some revision has a certain property then most likely a later revision
has the same property. We maximize the chances that someone's device
will work out of the box by making the range as large as possible.
But document in the source what precisely is needed, so that if we
find a later revision without the quirk, the limits can be adapted.

Andries