From: Doug Ledford <dledford@redhat.com>
To: James Bottomley <James.Bottomley@SteelEye.com>,
"Justin T. Gibbs" <gibbs@scsiguy.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: aic7xxx sets CDR offline, how to reset?
Date: Tue, 3 Sep 2002 18:52:51 -0400 [thread overview]
Message-ID: <20020903185251.H12201@redhat.com> (raw)
In-Reply-To: <20020903184216.F12201@redhat.com>; from dledford@redhat.com on Tue, Sep 03, 2002 at 06:42:16PM -0400
On Tue, Sep 03, 2002 at 06:42:16PM -0400, Doug Ledford wrote:
>
> Case 2: you want to do an abort, but you need to preserve ordering around
> any possible REQ_BARRIERs on the bus. This requires that we keep a
> REQ_BARRIER count for the device, it is after all possible that we could
> have multiple barriers active at once, so as each command is put on the
> active_list, if it is a barrier, then we increment SDpnt->barrier_count
> and as we complete commands (at the interrupt context completion, not the
> final completion) if it is a barrier command we decrement the count.
>
> [ oops we timed out ]
> while(SDpnt->barrier_count && cmd) {
> // when the aborted command is returned via the done()
> // it will remove it from the active_list, so don't remove
> // it here
> abort_cmd = list_get_tail(SDpnt->active_list);
> if(hostt->abort(abort_cmd) != SUCCESS) {
> [ oops, go on to more drastic action ]
> } else {
> if(abort_cmd->type == BARRIER)
> SDpnt->barrier_count--;
Oops, delete those last two lines....the done() function decrements the
barrier_count for us.
> if(abort_cmd == cmd)
> cmd = NULL;
> }
> }
> if(cmd) {
> if(hostt->abort(cmd) != SUCCESS)
> [ oops, go on to more drastic action ]
> }
--
Doug Ledford <dledford@redhat.com> 919-754-3700 x44233
Red Hat, Inc.
1801 Varsity Dr.
Raleigh, NC 27606
next prev parent reply other threads:[~2002-09-03 22:48 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-03 14:35 aic7xxx sets CDR offline, how to reset? James Bottomley
2002-09-03 18:23 ` Doug Ledford
2002-09-03 19:09 ` James Bottomley
2002-09-03 20:59 ` Alan Cox
2002-09-03 21:32 ` James Bottomley
2002-09-03 21:54 ` Alan Cox
2002-09-03 22:50 ` Doug Ledford
2002-09-03 23:28 ` Alan Cox
2002-09-04 7:40 ` Jeremy Higdon
2002-09-04 16:24 ` James Bottomley
2002-09-04 17:13 ` Mike Anderson
2002-09-05 9:50 ` Jeremy Higdon
2002-09-04 16:13 ` James Bottomley
2002-09-04 16:50 ` Justin T. Gibbs
2002-09-05 9:39 ` Jeremy Higdon
2002-09-05 13:35 ` Justin T. Gibbs
2002-09-03 21:13 ` Doug Ledford
2002-09-03 21:48 ` James Bottomley
2002-09-03 22:42 ` Doug Ledford
2002-09-03 22:52 ` Doug Ledford [this message]
2002-09-03 23:29 ` Alan Cox
2002-09-04 21:16 ` Luben Tuikov
2002-09-04 10:37 ` Andries Brouwer
2002-09-04 10:48 ` Doug Ledford
2002-09-04 11:23 ` Alan Cox
2002-09-04 16:25 ` Rogier Wolff
2002-09-04 19:34 ` Thunder from the hill
2002-09-03 21:24 ` Patrick Mansfield
2002-09-03 22:02 ` James Bottomley
2002-09-03 23:26 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2002-09-02 12:23 CAMTP guest
2002-09-02 15:50 ` Justin T. Gibbs
2002-09-02 18:05 ` Doug Ledford
2002-09-02 19:16 ` CAMTP guest
2002-09-02 19:48 ` Justin T. Gibbs
2002-09-02 19:42 ` Justin T. Gibbs
2002-06-11 2:46 Proposed changes to generic blk tag for use in SCSI (1/3) James Bottomley
2002-06-11 5:50 ` Jens Axboe
2002-06-11 14:29 ` James Bottomley
2002-06-11 14:45 ` Jens Axboe
2002-06-11 16:39 ` James Bottomley
2002-06-13 21:01 ` Doug Ledford
2002-06-13 21:26 ` James Bottomley
2002-06-13 21:50 ` Doug Ledford
2002-06-13 22:09 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020903185251.H12201@redhat.com \
--to=dledford@redhat.com \
--cc=James.Bottomley@SteelEye.com \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox