From: Christoph Hellwig <hch@infradead.org>
To: Karim Yaghmour <karim@opersys.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
LTT-Dev <ltt-dev@shafik.org>
Subject: Re: [PATCH] 1/8 LTT for 2.5.33: Core infrastructure
Date: Sat, 7 Sep 2002 02:28:48 +0100 [thread overview]
Message-ID: <20020907022848.A25996@infradead.org> (raw)
In-Reply-To: <3D792919.C40A2F02@opersys.com>; from karim@opersys.com on Fri, Sep 06, 2002 at 06:15:53PM -0400
On Fri, Sep 06, 2002 at 06:15:53PM -0400, Karim Yaghmour wrote:
> +endif
> +
> +ifdef CONFIG_TRACE
> +obj-y += trace.o
> endif
Please try to understand 2.4/2.5-style Makefile first.
>
> +/* Structure packing within the trace */
> +#if LTT_UNPACKED_STRUCTS
> +#define LTT_PACKED_STRUCT
> +#else /* if LTT_UNPACKED_STRUCTS */
> +#define LTT_PACKED_STRUCT __attribute__ ((packed))
> +#endif /* if LTT_UNPACKED_STRUCTS */
I can't see anything defining LTT_UNPACKED_STRUCTS in this patch.
> +int unregister_tracer
> + (tracer_call /* The tracer function */ );
Did you ever read Documentation/CodingStyle?
It would be helpful if you explain what exactly this patch doesm btw.
It's not really obvious from the the patch.
next prev parent reply other threads:[~2002-09-07 1:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-06 22:15 [PATCH] 1/8 LTT for 2.5.33: Core infrastructure Karim Yaghmour
2002-09-07 1:28 ` Christoph Hellwig [this message]
2002-09-07 3:03 ` Karim Yaghmour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020907022848.A25996@infradead.org \
--to=hch@infradead.org \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox