From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] USB changes for 2.5.34
Date: Mon, 9 Sep 2002 17:19:45 -0700 [thread overview]
Message-ID: <20020910001945.GB8477@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0209091714330.2069-100000@penguin.transmeta.com>
On Mon, Sep 09, 2002 at 05:17:40PM -0700, Linus Torvalds wrote:
>
> Greg, please don't do this
>
> > ChangeSet@1.614, 2002-09-05 08:33:20-07:00, greg@kroah.com
> > USB: storage driver: replace show_trace() with BUG()
>
> that BUG() thing is _way_ out of line, and has killed a few of my machines
> several times for no good reason. It actively hurts debuggability, because
> the machine is totally dead after it, and the whole and ONLY point of
> BUG() messages is to help debugging and make it clear that we can't handle
> something.
>
> In this case, we _can_ handle it, and we're much better off with a machine
> that works and that you can look up the messages with than killing it.
>
> Rule of thumb: BUG() is only good for something that never happens and
> that we really have no other option for (ie state is so corrupt that
> continuing is deadly).
Sorry, Matt told me to add it, I didn't realize the background. Should
I leave it as show_trace(), or just remove it? Do you want me to send
you another changeset to put it back?
thanks,
greg k-h
next prev parent reply other threads:[~2002-09-10 0:17 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-09 22:17 [BK PATCH] USB changes for 2.5.34 Greg KH
2002-09-10 0:17 ` Linus Torvalds
2002-09-10 0:19 ` Greg KH [this message]
2002-09-10 0:30 ` Linus Torvalds
2002-09-10 0:40 ` [linux-usb-devel] " Alan Cox
2002-09-10 1:41 ` Linus Torvalds
2002-09-10 1:48 ` Linus Torvalds
2002-09-10 10:23 ` Andries Brouwer
2002-09-10 0:35 ` Nicholas Miell
2002-09-10 1:01 ` [patch] dump_stack(): arch-neutral stack trace Andrew Morton
2002-09-15 4:34 ` Daniel Phillips
2002-09-15 4:51 ` Andrew Morton
2002-09-10 1:27 ` [BK PATCH] USB changes for 2.5.34 Linus Torvalds
2002-09-10 2:07 ` Matthew Dharm
2002-09-10 2:49 ` Linus Torvalds
2002-09-10 2:59 ` Linus Torvalds
2002-09-10 16:32 ` [linux-usb-devel] " David Brownell
2002-09-10 16:51 ` Linus Torvalds
2002-09-10 17:16 ` Jeff Garzik
2002-09-10 18:16 ` David S. Miller
2002-09-10 18:40 ` Linus Torvalds
2002-09-10 18:48 ` Jeff Garzik
2002-09-10 19:31 ` David S. Miller
2002-09-10 19:32 ` Oliver Xymoron
2002-09-10 19:38 ` Linus Torvalds
2002-09-10 19:43 ` Jeff Garzik
2002-09-10 21:52 ` Bill Davidsen
2002-09-10 22:02 ` Jeff Garzik
2002-09-10 18:44 ` Alan Cox
2002-09-10 19:03 ` Linus Torvalds
2002-09-10 19:27 ` Rik van Riel
2002-09-10 20:18 ` Alan Cox
2002-09-10 22:00 ` David Woodhouse
2002-09-10 22:23 ` Alan Cox
2002-09-10 22:26 ` David Woodhouse
2002-09-10 23:01 ` Alan Cox
2002-09-10 19:29 ` David S. Miller
2002-09-15 5:10 ` Daniel Phillips
2002-09-15 5:33 ` Daniel Berlin
2002-09-15 16:41 ` Daniel Phillips
2002-09-16 0:32 ` Horst von Brand
2002-09-15 6:07 ` Pete Zaitcev
2002-09-15 7:00 ` Andrew Morton
2002-09-15 20:05 ` David Woodhouse
2002-09-15 14:53 ` Daniel Phillips
2002-09-15 18:23 ` Pete Zaitcev
2002-09-15 18:34 ` Jeff Garzik
2002-09-16 0:55 ` Larry McVoy
2002-09-15 21:35 ` Rob Landley
2002-09-16 3:00 ` Larry McVoy
2002-09-16 3:08 ` Daniel Phillips
2002-09-16 11:16 ` Henning P. Schmiedehausen
2002-09-16 18:35 ` Thunder from the hill
2002-09-16 18:45 ` Daniel Phillips
2002-09-16 19:36 ` Thunder from the hill
2002-09-16 19:40 ` Daniel Phillips
2002-09-16 8:50 ` Ian Molton
2002-09-16 9:37 ` Rob Landley
2002-09-15 18:06 ` Linus Torvalds
2002-09-15 18:36 ` Roman Zippel
2002-09-15 19:04 ` Daniel Jacobowitz
2002-09-15 19:43 ` Andrew Morton
2002-09-15 19:43 ` Daniel Phillips
2002-09-15 23:24 ` Larry McVoy
2002-09-15 23:41 ` Daniel Jacobowitz
2002-09-15 23:52 ` Larry McVoy
2002-09-16 0:01 ` Robert Love
2002-09-16 1:29 ` Alan Cox
2002-09-16 2:13 ` Larry McVoy
2002-09-16 11:05 ` Henning P. Schmiedehausen
2002-09-16 14:05 ` Rogier Wolff
2002-09-16 16:24 ` Marco Colombo
2002-09-16 0:44 ` Daniel Phillips
2002-09-16 1:23 ` Alan Cox
2002-09-15 19:07 ` Daniel Phillips
2002-09-16 9:06 ` Jens Axboe
2002-09-16 14:14 ` David Woodhouse
2002-09-16 14:53 ` Jens Axboe
2002-09-16 15:15 ` Daniel Phillips
2002-09-16 15:59 ` kernel debuggers was [Re: [linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.34] Soewono Effendi
2002-09-15 19:08 ` [linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.34 Linus Torvalds
2002-09-15 19:10 ` Daniel Phillips
2002-09-15 19:26 ` Linus Torvalds
2002-09-15 19:32 ` Daniel Jacobowitz
2002-09-15 19:48 ` Daniel Phillips
2002-09-16 4:59 ` Jeff Dike
2002-09-16 4:05 ` Daniel Phillips
2002-09-16 4:55 ` Jeff Dike
2002-09-15 19:35 ` Daniel Phillips
2002-09-16 4:51 ` Jeff Dike
2002-09-16 15:29 ` Oliver Xymoron
2002-09-18 0:33 ` Rusty Russell
2002-09-18 0:46 ` Linus Torvalds
2002-09-18 0:50 ` Daniel Phillips
2002-09-18 1:16 ` Rik van Riel
2002-09-15 13:54 ` Rogier Wolff
2002-09-15 5:01 ` Daniel Phillips
2002-09-10 16:46 ` Thunder from the hill
2002-09-10 16:56 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020910001945.GB8477@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox