From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [patch] fix NMI watchdog, 2.5.34
Date: Tue, 10 Sep 2002 15:19:06 +1000 [thread overview]
Message-ID: <20020910054147.CD7972C201@lists.samba.org> (raw)
In-Reply-To: Your message of "Mon, 09 Sep 2002 21:45:20 +0200." <Pine.LNX.4.44.0209092144140.10544-100000@localhost.localdomain>
In message <Pine.LNX.4.44.0209092144140.10544-100000@localhost.localdomain> you
write:
>
> the attached patch fixes the NMI watchdog to trigger on all CPUs - the
> cpu_up() code broke it long time ago. With this patch NMI interrupts get
> generated on all CPUs, not just the boot CPU.
Well spotted. You might want to test the following patch which
catches calls to smp_call_function() before the cpus are actually
online. I ran a variant on my (crappy, old, SMP) box before I sent
the patch to Linus, and all I saw was the (harmless) tlb_flush.
diff -urNp --exclude TAGS -X /home/rusty/current-dontdiff --minimal linux-2.5.34/arch/i386/kernel/smp.c working-2.5.34-smp_call_cpus/arch/i386/kernel/smp.c
--- linux-2.5.34/arch/i386/kernel/smp.c Wed Aug 28 09:29:40 2002
+++ working-2.5.34-smp_call_cpus/arch/i386/kernel/smp.c Tue Sep 10 14:50:15 2002
@@ -561,9 +561,15 @@ int smp_call_function (void (*func) (voi
* hardware interrupt handler or from a bottom half handler.
*/
{
+ extern int smp_done;
struct call_data_struct data;
int cpus = num_online_cpus()-1;
+ if (!smp_done) {
+ printk(KERN_ERR "smp_call_function %p called before SMP!\n",
+ func);
+ show_stack(NULL);
+ }
if (!cpus)
return 0;
diff -urNp --exclude TAGS -X /home/rusty/current-dontdiff --minimal linux-2.5.34/arch/i386/kernel/smpboot.c working-2.5.34-smp_call_cpus/arch/i386/kernel/smpboot.c
--- linux-2.5.34/arch/i386/kernel/smpboot.c Sun Sep 1 12:22:57 2002
+++ working-2.5.34-smp_call_cpus/arch/i386/kernel/smpboot.c Tue Sep 10 14:35:07 2002
@@ -1218,7 +1218,10 @@ int __devinit __cpu_up(unsigned int cpu)
return 0;
}
+unsigned int smp_done = 0;
+
void __init smp_cpus_done(unsigned int max_cpus)
{
zap_low_mappings();
+ smp_done = 1;
}
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-09-10 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-09 19:45 [patch] fix NMI watchdog, 2.5.34 Ingo Molnar
2002-09-10 5:19 ` Rusty Russell [this message]
2002-09-10 18:11 ` Zwane Mwaikambo
2002-09-12 7:48 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020910054147.CD7972C201@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox