From: Rusty Russell <rusty@rustcorp.com.au>
To: "David S. Miller" <davem@redhat.com>
Cc: pavel@suse.cz, torvalds@transmeta.com,
linux-kernel@vger.kernel.org, akpm@zip.com.au
Subject: Re: [PATCH] Important per-cpu fix.
Date: Tue, 10 Sep 2002 19:41:05 +1000 [thread overview]
Message-ID: <20020910094045.695DD2C363@lists.samba.org> (raw)
In-Reply-To: Your message of "Mon, 09 Sep 2002 01:15:39 MST." <20020909.011539.122194350.davem@redhat.com>
In message <20020909.011539.122194350.davem@redhat.com> you write:
> I want *you* to feel the pain, not spread it around by leaving turds
> throughout the code long after the bug is forgotten:
>
> Aha, but it is you putting the turd comments all over. I'm
> suggesting to put the turd in one place, the header file.
.... and every user of it...
> And how difficult is it to discern which initializers were
> needed? Hmmm let me see, if it was all zero --> removing it
> is harmless.
Let's not get onto initializer wars: I initialize all my variables
exactly once, so there's serious semantic difference between "static
int x;" and "static int x = 0;" in my code.
> Both of us are advocating adding shit to the tree, the only argument
> is which stinks less from a maintainence perspective.
Hey, I'm not stopping you sending a patch to Linus, but given how we
deprecated compilers on x86, I don't think he'll have sympathy for
you in 2.6.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-09-10 9:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-04 2:35 [PATCH] Important per-cpu fix Rusty Russell
2002-09-04 2:54 ` David S. Miller
2002-09-04 4:04 ` Rusty Russell
2002-09-04 4:52 ` H. Peter Anvin
2002-09-09 8:06 ` Rusty Russell
2002-09-09 8:16 ` David S. Miller
2002-09-04 5:05 ` David S. Miller
2002-09-04 5:17 ` Linus Torvalds
2002-09-04 5:12 ` David S. Miller
2002-09-04 6:00 ` Rusty Russell
2002-09-04 6:06 ` David S. Miller
2002-09-04 6:19 ` David S. Miller
2002-09-04 7:38 ` Rusty Russell
2002-09-06 9:57 ` Pavel Machek
2002-09-09 3:45 ` Rusty Russell
2002-09-09 6:13 ` David S. Miller
2002-09-09 8:17 ` Rusty Russell
2002-09-09 8:15 ` David S. Miller
2002-09-09 20:58 ` Alan Cox
2002-09-09 21:06 ` Andrew Morton
2002-09-10 9:41 ` Rusty Russell [this message]
2002-09-04 15:44 ` Thunder from the hill
2002-09-04 23:18 ` David S. Miller
2002-09-04 2:56 ` Andrew Morton
2002-09-04 2:46 ` William Lee Irwin III
2002-09-04 3:42 ` William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2002-09-05 9:10 Dipankar Sarma
2002-09-05 9:09 ` William Lee Irwin III
2002-09-05 19:08 ` Dipankar Sarma
2002-09-05 19:11 ` William Lee Irwin III
2002-09-09 12:17 Matthew Wilcox
2002-09-09 23:24 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020910094045.695DD2C363@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=akpm@zip.com.au \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox