From: Jens Axboe <axboe@suse.de>
To: Martin Knoblauch <martin.knoblauch@mscsoftware.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Oops + Aiee when mounting CDROM via ide-scsi under 2.4.20-pre5-ac4
Date: Tue, 10 Sep 2002 21:09:06 +0200 [thread overview]
Message-ID: <20020910190906.GI21877@suse.de> (raw)
In-Reply-To: <200209102015.51536.martin.knoblauch@mscsoftware.com>
On Tue, Sep 10 2002, Martin Knoblauch wrote:
> Hi,
>
> I am getting a reproducable Oops+Aiee when trying to mount a ATAPI
> CDROM via the ide-scsi interface under 2.4.20-pre5-ac4. Works OK
> without ide-scsi.
Ok, the problem is that ide-scsi builds a request which eventually ends
up going through the ide code dma mapping. ide_build_sglist() does a
rq_data_dir() on the request, which BUG()'s if the command isn't an fs
read or write. This actually went undetected before, because the ide
code did:
if (rq->cmd == READ)
direction is dma from device
else
direction is to device
and rq->cmd is IDESCSI_PC_RQ in this case. So we always mapped for dma
to the device, even if that wasn't the case.
Hmm, maybe just adding a single direction bit to struct request is the
easy way out for 2.4. Or... I'll cook something up.
--
Jens Axboe
next prev parent reply other threads:[~2002-09-10 19:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-10 18:15 Oops + Aiee when mounting CDROM via ide-scsi under 2.4.20-pre5-ac4 Martin Knoblauch
2002-09-10 19:09 ` Jens Axboe [this message]
2002-09-10 19:13 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2002-09-11 10:28 Martin Knoblauch
2002-09-11 10:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020910190906.GI21877@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.knoblauch@mscsoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox