public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] Re: 2.5.3[3,4] Preemption problem
  2002-09-09 21:31 Paolo Ciarrocchi
@ 2002-09-10 19:44 ` Robert Love
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2002-09-10 19:44 UTC (permalink / raw)
  To: Paolo Ciarrocchi; +Cc: linux-kernel

On Mon, 2002-09-09 at 17:31, Paolo Ciarrocchi wrote:

> Halting system...
> Shutting down devices
> Power down.
> note: halt[15347] exited with preempt_count 1

I cooked up a patch... does this solve the problem (no more spurious
warning on reboot)?

Patch is against 2.5.34.

	Robert Love

diff -urN linux-2.5.34/kernel/sys.c linux/kernel/sys.c
--- linux-2.5.34/kernel/sys.c	Tue Sep 10 13:04:49 2002
+++ linux/kernel/sys.c	Tue Sep 10 15:40:35 2002
@@ -316,7 +316,7 @@
 
 	/* For safety, we require "magic" arguments. */
 	if (magic1 != LINUX_REBOOT_MAGIC1 ||
-	    (magic2 != LINUX_REBOOT_MAGIC2 && magic2 != LINUX_REBOOT_MAGIC2A &&
+	   (magic2 != LINUX_REBOOT_MAGIC2 && magic2 != LINUX_REBOOT_MAGIC2A &&
 			magic2 != LINUX_REBOOT_MAGIC2B))
 		return -EINVAL;
 
@@ -344,6 +344,7 @@
 		device_shutdown();
 		printk(KERN_EMERG "System halted.\n");
 		machine_halt();
+		unlock_kernel();
 		do_exit(0);
 		break;
 
@@ -353,6 +354,7 @@
 		device_shutdown();
 		printk(KERN_EMERG "Power down.\n");
 		machine_power_off();
+		unlock_kernel();
 		do_exit(0);
 		break;
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] Re: 2.5.3[3,4] Preemption problem
@ 2002-09-10 21:54 Paolo Ciarrocchi
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Ciarrocchi @ 2002-09-10 21:54 UTC (permalink / raw)
  To: rml; +Cc: linux-kernel

From: Robert Love <rml@tech9.net>
> On Mon, 2002-09-09 at 17:31, Paolo Ciarrocchi wrote:
> 
> > Halting system...
> > Shutting down devices
> > Power down.
> > note: halt[15347] exited with preempt_count 1
> 
> I cooked up a patch... does this solve the problem (no more spurious
> warning on reboot)?
Yes it does.
Thank you.

Ciao,
           Paolo
-- 
Get your free email from www.linuxmail.org 


Powered by Outblaze

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-09-10 21:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-09-10 21:54 [patch] Re: 2.5.3[3,4] Preemption problem Paolo Ciarrocchi
  -- strict thread matches above, loose matches on Subject: below --
2002-09-09 21:31 Paolo Ciarrocchi
2002-09-10 19:44 ` [patch] " Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox