From: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>
To: "Jens Axboe" <axboe@suse.de>, "Paul Mackerras" <paulus@samba.org>
Cc: <marcelo@conectiva.com.br>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] highmem I/O for ide-pmac.c
Date: Wed, 11 Sep 2002 20:53:15 +0200 [thread overview]
Message-ID: <20020911185315.530@192.168.4.1> (raw)
In-Reply-To: <20020911130209.GL1089@suse.de>
>BTW, it would be ok to export that from ide-dma.c instead of duplicating
>it in ide-pmac.
It isn't. ide-pmac doesn't use the sg_table & other DMA related
fields in HWIF, but it's own copies in the "pmif" which is a
parallel data structure.
It sucks, I know, but I have to do that with the current IDE code
as the common code would make assumption about the format of these
things and it's right to dispose them in ide_unregister.
Also, Jens is right, Paul, you never call pmac_ide_toggle_bounce()
to actually enable high IOs. Add that to the ide_dma_on/check: case,
with an if (drive->using_dma) (as enabling DMA may have failed)
Or just wait for me to finish fixing my 6xx power save on idle
stuff and I'll send an updated patch to Marcelo along with other
pmac stuffs. (I'm implementing your suggestion of comparing SRR0
content in transfer_to_handler, but so far, the comparison never
seem to match, I'll find that out soon enough though).
Ben.
next prev parent reply other threads:[~2002-09-11 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-11 12:48 [PATCH] highmem I/O for ide-pmac.c Paul Mackerras
2002-09-11 13:02 ` Jens Axboe
2002-09-11 13:07 ` Jens Axboe
2002-09-11 13:13 ` Jens Axboe
2002-09-11 18:53 ` Benjamin Herrenschmidt [this message]
2002-09-11 18:05 ` Jens Axboe
2002-09-12 6:54 ` Paul Mackerras
2002-09-12 6:59 ` Jens Axboe
2002-09-12 6:12 ` Paul Mackerras
2002-09-12 6:20 ` Jens Axboe
2002-09-12 5:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020911185315.530@192.168.4.1 \
--to=benh@kernel.crashing.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox