From: Jens Axboe <axboe@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] highmem I/O for ide-pmac.c
Date: Thu, 12 Sep 2002 08:59:03 +0200 [thread overview]
Message-ID: <20020912065903.GM30234@suse.de> (raw)
In-Reply-To: <15744.14859.966809.289502@argo.ozlabs.ibm.com>
On Thu, Sep 12 2002, Paul Mackerras wrote:
> Jens Axboe writes:
>
> > The above refers to ide_toggle_bounce() export, pmac_* variant is
> > exactly the same. Sorry if that wasn't clear.
>
> Why does ide_toggle_bounce assume we can only do DMA to highmem if
> drive->media == ide_disk? At the moment I can't see any reason why
> the ide-pmac interface can't do DMA to highmem for a cdrom, for
> instance.
Because it requires changes to the personality driver (ie ide-disk,
ide-cd, etc). I only did those changes to ide-disk, didn't figure it was
worthwhile to do for ide-cd for instance. It's not exactly a
high-performance media :-)
If the device is always in dma mode, no changes are needed. It's when
you drop to pio the problem arises, and all the interrupt handlers need
to be fixed.
--
Jens Axboe
next prev parent reply other threads:[~2002-09-12 6:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-11 12:48 [PATCH] highmem I/O for ide-pmac.c Paul Mackerras
2002-09-11 13:02 ` Jens Axboe
2002-09-11 13:07 ` Jens Axboe
2002-09-11 13:13 ` Jens Axboe
2002-09-11 18:53 ` Benjamin Herrenschmidt
2002-09-11 18:05 ` Jens Axboe
2002-09-12 6:54 ` Paul Mackerras
2002-09-12 6:59 ` Jens Axboe [this message]
2002-09-12 6:12 ` Paul Mackerras
2002-09-12 6:20 ` Jens Axboe
2002-09-12 5:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020912065903.GM30234@suse.de \
--to=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox