From: Jens Axboe <axboe@suse.de>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: andre@linux-ide.org, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: Patch: linux-2.5.34/drivers/ide/ide.c was building list of drives in reverse order
Date: Thu, 12 Sep 2002 13:52:22 +0200 [thread overview]
Message-ID: <20020912115222.GA30234@suse.de> (raw)
In-Reply-To: <20020912044851.A382@baldur.yggdrasil.com>
On Thu, Sep 12 2002, Adam J. Richter wrote:
> ata_attach in linux-2.5.34/drivers/ide/ide.c builds a list of
> IDE drives that do not yet have a device driver bound to them, in case
> ide-disk, ide-scsi, or whatever driver you want to use is not loaded
> yet.
>
> The problem was that ata_attach was adding to the head of
> the list, so the list was being built in reverse order. So, if
> you had two IDE disks, and ide-disk was a loadable module, the
> devfs entries for the disks would be numbered in reverse (the
> first disk would be /dev/discs/disc1, and the second would be
> /dev/discs/disc0).
>
> The follow patch fixes the problem by changing the relevant
> list_add to list_add_tail. Incidentally, the generic code
> in drivers/base/ already does it this way.
Patch looks right (its obviously the right thing to do), thanks
--
Jens Axboe
prev parent reply other threads:[~2002-09-12 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-12 11:48 Patch: linux-2.5.34/drivers/ide/ide.c was building list of drives in reverse order Adam J. Richter
2002-09-12 11:52 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020912115222.GA30234@suse.de \
--to=axboe@suse.de \
--cc=adam@yggdrasil.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox