From: Matthew Wilcox <willy@debian.org>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: torvalds@transmeta.com, willy@debian.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.34-bk fcntl lockup
Date: Sat, 14 Sep 2002 14:41:18 +0100 [thread overview]
Message-ID: <20020914144118.C10583@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20020914101811.GA1447@ppc.vc.cvut.cz>; from vandrove@vc.cvut.cz on Sat, Sep 14, 2002 at 12:18:11PM +0200
On Sat, Sep 14, 2002 at 12:18:11PM +0200, Petr Vandrovec wrote:
> Hi Linus,
> please apply this.
agreed, please apply.
> Fixes endless loop without schedule which happens as soon as smbd
> invokes fcntl64(7, F_SETLK64, ...). fcntl_setlk64 gets cmd F_SETLK64,
> not F_SETLK tested in the loop;
i guess the LTP testsuite isn't quite comprehensive enough yet, it should
have caught this.
> Maybe return value from posix_lock_file should be changed to -EINPROGRESS
> or -EJUKEBOX instead of testing passed cmd in callers, but this oneliner
> works too. If you preffer changing posix_lock_file return value to clearly
> distinugish between -EAGAIN and lock request queued, I'll do that.
i'll look at that idea, hadn't occurred to me before.
--
Revolutions do not require corporate support.
prev parent reply other threads:[~2002-09-14 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-14 10:18 [PATCH] 2.5.34-bk fcntl lockup Petr Vandrovec
2002-09-14 13:41 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020914144118.C10583@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox