public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Werner Almesberger <wa@almesberger.net>
To: Ravikiran G Thirumalai <kiran@in.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Question regarding Qdisc.stats
Date: Sun, 15 Sep 2002 02:46:16 -0300	[thread overview]
Message-ID: <20020915024616.B3352@almesberger.net> (raw)
In-Reply-To: <20020820171431.K1992@in.ibm.com>; from kiran@in.ibm.com on Tue, Aug 20, 2002 at 05:14:31PM +0530

Ravikiran G Thirumalai wrote:
> Where do the Qdisc.stats show up? in /proc?

No, only on (rt)netlink.

> (Assuming CONFIG_NET_SCHED is not defined)

In this case, the statistics are not usefully accessible. The
tx_dropped you get with ifconfig (or such) comes from the device
level, not the traffic control subsystem.

> qdisc_copy_stats with 'TCA_STATS' attribute, but where is it being 
> reported? or what is it being used for ?? Specifically, does 
> Qdisc.stats.drops get reported anywere?

Yep, e.g. in iproute2/tc/tc_qdisc.c:print_tcstats

> While I am at it, I see that qdisc->enqueue routines kfree the skb with the
> dev->queue_lock held (when the enqueue routine drops the packet -- 
> NET_XMIT_DROP)  from dev_queue_xmit. kfree_skb can be done outside the 
> lock.... right? I can make a patch for this if I am not missing something.....

That certainly sounds good to me.

- Werner

-- 
  _________________________________________________________________________
 / Werner Almesberger, Buenos Aires, Argentina         wa@almesberger.net /
/_http://www.almesberger.net/____________________________________________/

      reply	other threads:[~2002-09-16  1:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-20 11:44 Question regarding Qdisc.stats Ravikiran G Thirumalai
2002-09-15  5:46 ` Werner Almesberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020915024616.B3352@almesberger.net \
    --to=wa@almesberger.net \
    --cc=kiran@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox