Re: [BK PATCH] USB changes for 2.5.34

Linus Torvalds
2002-09-10T00:22:30Z

On Mon, 9 Sep 2002, Greg KH wrote:
>
> Sorry, Matt told me to add it, I didn't realize the background. Should
> I leave it as show_trace(), or just remove it? Do you want me to send
> you another changeset to put it back?

I've just excluded it, with a comment to never _ever_ kill the machine
unless there is a major reason for it.

We might want to add some "weaker" form of BUG_ON() for sanity checks that
aren't life-threatening (ie a "CHECK(a == b)" kind of debug facility) that
would be prettier than doing printk's and show_trace(), and that would
also be easier to disable for production kernels (not that I personally
much believe in disabling debugging like that - if it really isn't needed
it should be removed, not disabled).

Linus