From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Adrian Bunk <bunk@fs.tum.de>, torvalds@transmeta.com
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] 2.5.35 drivers/atm/firestream.c __FUNCTION__ fix
Date: Tue, 17 Sep 2002 14:47:10 -0700 [thread overview]
Message-ID: <20020917144710.C94419@sfgoth.com> (raw)
In-Reply-To: <Pine.NEB.4.44.0209171033460.26796-100000@mimas.fachschaften.tu-muenchen.de>; from bunk@fs.tum.de on Tue, Sep 17, 2002 at 10:37:30AM +0200
Adrian Bunk wrote:
> Thanks for this patch, the next compile error is that compilation of
> firestream.c fails at all occurences of func_enter:
This is just the breakage that newer gcc's provoke when you try to use
__FUNCTION__ as a string constant. Easy fix (included at end of message,
Linus please apply)
> > -Mitch (deadbeat ATM maintainer)
>
> I didn't Cc you because you are only listed as PPP OVER ATM (RFC 2364)
> maintainer in MAINTAINERS. Do you now maintain the complete ATM subsystem?
I'm sort of the maintainer, if there is one at all. Werner handed me the
torch a year and a half ago since he has other projects and I was one of
the few people still hacking on the core ATM code. At the time I was doing
some related work so it fit naturally. Unfortunately, I'm not working
in that field at the moment and my other commitments are taking about 110%
of my time. I've been trying to keep it sort of maintained in the meantime
(keeping it compiling, basic mailing list admin) but sadly that's been about
it from me lately. :-(
-Mitch
--- linux-2.5.35-VIRGIN/drivers/atm/firestream.c 2002-08-24 00:08:21.000000000 -0700
+++ linux-2.5.35/drivers/atm/firestream.c 2002-09-17 14:34:57.000000000 -0700
@@ -330,8 +330,8 @@
#define FS_DEBUG_QSIZE 0x00001000
-#define func_enter() fs_dprintk (FS_DEBUG_FLOW, "fs: enter " __FUNCTION__ "\n")-#define func_exit() fs_dprintk (FS_DEBUG_FLOW, "fs: exit " __FUNCTION__ "\n")+#define func_enter() fs_dprintk (FS_DEBUG_FLOW, "fs: enter %s\n", __FUNCTION__)+#define func_exit() fs_dprintk (FS_DEBUG_FLOW, "fs: exit %s\n", __FUNCTION__)
struct fs_dev *fs_boards = NULL;
prev parent reply other threads:[~2002-09-17 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-16 2:32 Linux 2.5.35 Linus Torvalds
2002-09-16 10:08 ` Adrian Bunk
2002-09-16 10:27 ` David Woodhouse
2002-09-16 11:52 ` Adrian Bunk
2002-09-16 18:20 ` Linux 2.5.35 xtime locking Rolf Fokkens
2002-09-17 4:23 ` [PATCH] 2.5.35 atm driver compile fix Mitchell Blank Jr
2002-09-17 8:37 ` Adrian Bunk
2002-09-17 21:47 ` Mitchell Blank Jr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020917144710.C94419@sfgoth.com \
--to=mitch@sfgoth.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox