From: Russell King <rmk@arm.linux.org.uk>
To: Patrick Mochel <mochel@osdl.org>,
Linus Torvalds <torvalds@transmeta.com>
Cc: Stuart MacDonald <stuartm@connecttech.com>, linux-kernel@vger.kernel.org
Subject: Re: linux-2.5.36 Oops on power-down
Date: Thu, 19 Sep 2002 11:41:15 +0100 [thread overview]
Message-ID: <20020919114115.B11763@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0209181558440.968-100000@cherise.pdx.osdl.net>; from mochel@osdl.org on Wed, Sep 18, 2002 at 04:01:53PM -0700
On Wed, Sep 18, 2002 at 04:01:53PM -0700, Patrick Mochel wrote:
> It appears that the 8250_pci serial driver needs a check for NULL when
> calling the device's re-init function. Could you try the attached patch
> and let us know if it works for you?
The patch is correct. Linus, please apply.
===== drivers/serial/8250_pci.c 1.8 vs edited =====
--- 1.8/drivers/serial/8250_pci.c Mon Jul 29 07:52:41 2002
+++ edited/drivers/serial/8250_pci.c Wed Sep 18 15:51:32 2002
@@ -771,7 +771,8 @@
for (i = 0; i < priv->nr; i++)
unregister_serial(priv->line[i]);
- priv->board->init_fn(dev, priv->board, 0);
+ if (priv->board->init_fn)
+ priv->board->init_fn(dev, priv->board, 0);
pci_disable_device(dev);
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
prev parent reply other threads:[~2002-09-19 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 22:17 linux-2.5.36 Oops on power-down Stuart MacDonald
2002-09-18 23:01 ` Patrick Mochel
2002-09-18 23:41 ` Stuart MacDonald
2002-09-19 10:41 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020919114115.B11763@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=stuartm@connecttech.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox