From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: thunder@lightweight.ods.org, linux-kernel@vger.kernel.org
Subject: Re: FW: 2.5.34: IR __FUNCTION__ breakage
Date: Fri, 20 Sep 2002 10:13:15 -0700 [thread overview]
Message-ID: <20020920171314.GD8260@bougret.hpl.hp.com> (raw)
In-Reply-To: <MNEMKBGMDIMHCBHPHLGPMEEDDDAA.dag@brattli.net>
On Fri, Sep 13, 2002 at 08:25:50AM +0200, Dag Brattli wrote:
> -----Original Message-----
> From: Thunder from the hill [mailto:thunder@lightweight.ods.org]
> Sent: 12. september 2002 22:17
> To: Bob_Tracy
> Cc: dag@brattli.net; linux-kernel@vger.kernel.org
> Subject: Re: 2.5.34: IR __FUNCTION__ breakage
>
>
> Hi,
>
> On Thu, 12 Sep 2002, Bob_Tracy wrote:
> > define DERROR(dbg, args...) \
> > {if(DEBUG_##dbg){\
> > printk(KERN_INFO "irnet: %s(): ", __FUNCTION__);\
> > printk(KERN_INFO args);}}
> >
> > which strikes me as not quite what the author intended, although it
> > should work.
>
> Why not
>
> #define DERROR(dbg, fmt, args...) \
> do { if (DEBUG_##dbg) \
> printk(KERN_INFO "irnet: %s(): " fmt, __FUNCTION, args); \
> } while(0)
>
> ?
>
> Thunder
Try it, it won't work when there is zero args.
Jean
next parent reply other threads:[~2002-09-20 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <MNEMKBGMDIMHCBHPHLGPMEEDDDAA.dag@brattli.net>
2002-09-20 17:13 ` Jean Tourrilhes [this message]
2002-09-20 17:17 ` FW: 2.5.34: IR __FUNCTION__ breakage Jeff Garzik
2002-09-20 17:19 ` Jean Tourrilhes
2002-09-20 18:10 ` Bjoern A. Zeeb
2002-09-20 21:41 ` Neil Booth
2002-09-20 22:11 ` Jean Tourrilhes
2002-09-20 17:25 ` Thunder from the hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020920171314.GD8260@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder@lightweight.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox