Re: 2.5.38-mm2 [PATCH]

Andrew Morton
2002-09-23T19:11:05Z

Dipankar Sarma wrote:
>
> ...
> -#ifdef CONFIG_PREEMPTION
> +#ifdef CONFIG_PREEMPT
> #define rcu_read_lock() preempt_disable()
> #define rcu_read_unlock() preempt_enable()
> #else

Thanks. I just replaced

#ifdef CONFIG_PREEMPTION
#define rcu_read_lock() preempt_disable()
#define rcu_read_unlock() preempt_enable()
#else
#define rcu_read_lock() do {} while(0)
#define rcu_read_unlock() do {} while(0)
#endif

with

#define rcu_read_lock() preempt_disable()
#define rcu_read_unlock() preempt_enable()

because preempt_disable() is a no-op on CONFIG_PREEMPT=n anyway.