From: Pete Zaitcev <zaitcev@redhat.com>
To: Tomas Szepe <szepe@pinerecords.com>
Cc: "David S. Miller" <davem@redhat.com>,
zaitcev@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: sparc32 sunrpc.o
Date: Sun, 29 Sep 2002 19:56:12 -0400 [thread overview]
Message-ID: <20020929195612.A3218@devserv.devel.redhat.com> (raw)
In-Reply-To: <20020929102238.GD4323@louise.pinerecords.com>; from szepe@pinerecords.com on Sun, Sep 29, 2002 at 12:22:39PM +0200
> Date: Sun, 29 Sep 2002 12:22:39 +0200
> From: Tomas Szepe <szepe@pinerecords.com>
> +++ linux-2.4.20-pre8/arch/sparc/kernel/sparc_ksyms.c 2002-09-29 11:45:33.000000000 +0200
> +#ifdef CONFIG_HIGHMEM
> +#include <asm/highmem.h>
> +#endif
OK, this is actually correct, I think. Looks funny. :)
> +++ linux-2.4.20-pre8/arch/sparc/mm/Makefile 2002-09-29 11:45:33.000000000 +0200
> @@ -11,7 +11,7 @@
> $(CC) $(AFLAGS) -ansi -c -o $*.o $<
>
> O_TARGET := mm.o
> -obj-y := fault.o init.o loadmmu.o generic.o extable.o btfixup.o
> +obj-y := fault.o init.o loadmmu.o generic.o extable.o highmem.o btfixup.o
Why is this not obj-$(CONFIG_HIGHMEM) ?
> +/* in mm/memory.c */
> +extern struct page *highmem_start_page;
> +
I would not do this. I would try to include <linux/highmem.h>
into arch/sparc/mm/highmem.c (instead of <asm/highmem.h> as you did).
Also, now that you moved a bunch of implementation out of inlines,
try to trim the #include list at the top of <asm-sparc/highmem.h>.
For instance, asm/vaddrs.h is a suspect.
The rest of the patch is sane, as far as I can tell. I do not
have a ready to run 2.4 sparc box, sorry. Please ask sparclinux@vger
people to test, especially Uzi.
-- Pete
next prev parent reply other threads:[~2002-09-29 23:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1033072381.13688.linux-kernel2news@redhat.com>
2002-09-26 21:27 ` sparc32 sunrpc.o Pete Zaitcev
2002-09-26 21:29 ` David S. Miller
2002-09-28 12:28 ` Tomas Szepe
2002-09-28 16:13 ` Tomas Szepe
2002-09-29 6:23 ` David S. Miller
2002-09-29 10:22 ` Tomas Szepe
2002-09-29 23:56 ` Pete Zaitcev [this message]
2002-09-30 0:50 ` David S. Miller
2002-09-30 2:05 ` Horst von Brand
2002-09-30 2:09 ` Tomas Szepe
2002-09-26 20:25 Tomas Szepe
2002-09-26 21:09 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020929195612.A3218@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=szepe@pinerecords.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox