public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* init ordering bug in 802/psnap.c vs llc/llc_main.c
@ 2002-09-30  1:21 Andries.Brouwer
  2002-09-30  1:24 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 2+ messages in thread
From: Andries.Brouwer @ 2002-09-30  1:21 UTC (permalink / raw)
  To: Andries.Brouwer, acme; +Cc: linux-kernel, torvalds

> Humm, 2.5.39? It is compiled statically, isn't it?
> I'm working exclusively with modules up to now

A good hint. llc/llc_main.c crashes in llc_sap_find()
because llc_init() has not yet been called, so that
llc_main_station.sap_list.list is not initialized.

And llc_sap_find() was called from 802/psnap.c, in snap_init().

Calling llc_init() and snap_init() in the right order
makes the oops go away.

Andries

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: init ordering bug in 802/psnap.c vs llc/llc_main.c
  2002-09-30  1:21 init ordering bug in 802/psnap.c vs llc/llc_main.c Andries.Brouwer
@ 2002-09-30  1:24 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2002-09-30  1:24 UTC (permalink / raw)
  To: Andries.Brouwer; +Cc: linux-kernel, torvalds

Em Mon, Sep 30, 2002 at 03:21:12AM +0200, Andries.Brouwer@cwi.nl escreveu:
> > Humm, 2.5.39? It is compiled statically, isn't it?
> > I'm working exclusively with modules up to now
> 
> A good hint. llc/llc_main.c crashes in llc_sap_find()
> because llc_init() has not yet been called, so that
> llc_main_station.sap_list.list is not initialized.
> 
> And llc_sap_find() was called from 802/psnap.c, in snap_init().
> 
> Calling llc_init() and snap_init() in the right order
> makes the oops go away.

Thanks for investigating and reporting :-)

- Arnaldo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-09-30  1:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-09-30  1:21 init ordering bug in 802/psnap.c vs llc/llc_main.c Andries.Brouwer
2002-09-30  1:24 ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox