From: Art Haas <ahaas@neosoft.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] vmalloc.c fix for 2.4.20-pre8-ac2
Date: Mon, 30 Sep 2002 14:08:39 -0500 [thread overview]
Message-ID: <20020930190839.GA1584@debian> (raw)
Hi.
I noticed this when building 2.4.20-pre8-ac2 ...
gcc -D__KERNEL__ -I/usr/src/linux-2.4.20-pre8-ac2/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i586
-nostdinc -iwithprefix include -DKBUILD_BASENAME=vmalloc -c -o
vmalloc.o vmalloc.c
vmalloc.c: In function `get_vm_area':
vmalloc.c:182: warning: passing arg 1 of `kfree' makes pointer from
integer without a cast
vmalloc.c:173: warning: `addr' might be used uninitialized in this
function
I peek at vmalloc.c shows what looks to be a typo. The variable
'area' is allocated by kmalloc(), and 'addr' is a local variable
that hasn't been set. Trying to kfree() it would probably be
a bad thing.
Art Haas
--- linux-2.4.20-pre8-ac2/mm/vmalloc.c.ac2 2002-09-30 11:49:32.000000000 -0500
+++ linux-2.4.20-pre8-ac2/mm/vmalloc.c 2002-09-30 13:59:30.000000000 -0500
@@ -179,7 +179,7 @@
size += PAGE_SIZE;
if (!size) {
- kfree (addr);
+ kfree (area);
return NULL;
}
--
They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety.
-- Benjamin Franklin, Historical Review of Pennsylvania, 1759
reply other threads:[~2002-09-30 19:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020930190839.GA1584@debian \
--to=ahaas@neosoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox