public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: linux-kernel@vger.kernel.org
Subject: Sigh, any ideas for a "dump_stack" name?
Date: Wed, 2 Oct 2002 10:59:33 +0100	[thread overview]
Message-ID: <20021002105933.A24770@flint.arm.linux.org.uk> (raw)

Ok,

Still not got 2.5.40 to build...

ARM has, since the year dot, used "dump_stack()" to display any threads
stack, and has the following prototype:

static void dump_stack(struct task_struct *tsk, unsigned long sp)

However, somewhere in the 2.5.34 -> 2.5.40 development, "dump_stack" got
used as a way to call "show_stack" with a value of zero on x86 (which is
another externally visible function.)

Firstly, "dump_stack" is misnamed.  It dumps stack and call trace
information.

Secondly, it creates a small problem - we're running out of names
to describe a function that displays _just_ stack contents without
any call trace information.

So, I propose to change the ARM version to the following, unless someone
else can come up with another name or a fix the poliferation of stack-
displaying functions that the generic kernel seems to require.

dump_random_numbers_from_thread_stack_yes_a_very_long_name_that_wont_clash_with_anything_else()

(Note: it may be a static function, but it is useful on to make it public
for occasional debugging.)

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


             reply	other threads:[~2002-10-02  9:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-02  9:59 Russell King [this message]
2002-10-02 16:55 ` Sigh, any ideas for a "dump_stack" name? Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021002105933.A24770@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox