From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alessandro Amici <alexamici@tiscali.it>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com
Subject: Re: 2.5.37+ i386 arch split broke external module builds
Date: Wed, 02 Oct 2002 18:09:46 -0400 [thread overview]
Message-ID: <200210022209.g92M9kh02253@localhost.localdomain> (raw)
In-Reply-To: Message from Alessandro Amici <alexamici@tiscali.it> of "Wed, 02 Oct 2002 12:39:32 +0200." <20021002103932.C35A21EA74@alan.localdomain>
alexamici@tiscali.it said:
> comments are welcome,
-#include "irq_vectors.h"
+#ifdef CONFIG_VISWS
+#include <asm/mach-visws/irq_vectors.h>
+#else
+#include <asm/mach-generic/irq_vectors.h>
+#endif
I'm afraid the whole purpose of the code was to get away from this type of
#ifdef problem. If you do this, every new mach-type added to i386 has to
modify a bunch of kernel headers.
dwmw2@infradead.org said:
> make -C /lib/modules/`uname -r`/build SUBDIRS=`pwd` modules
This looks like a clean solution to me, since most kernel packages install
this module build directory.
James
next prev parent reply other threads:[~2002-10-02 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-02 10:39 2.5.37+ i386 arch split broke external module builds Alessandro Amici
2002-10-02 11:28 ` David Woodhouse
2002-10-02 21:06 ` Alessandro Amici
2002-10-02 21:13 ` David Woodhouse
2002-10-02 22:09 ` James Bottomley [this message]
2002-10-02 23:49 ` Alessandro Amici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210022209.g92M9kh02253@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=alexamici@tiscali.it \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox