[PATCH] Bodge up serial support in 2.5.40

[PATCH] Bodge up serial support in 2.5.40

[jbradford]

Standard 8250/16550 UART support is broken in 2.5.40, and I needed it, so following a bit of advice from Russell King, I've prepared this patch.

I thought I'd post it, just incase anybody else out there actually uses serial ports, (seems they don't).  Before you apply it, bear in mind that the last C I did was a hello world program :-), (only half kidding).

This is a bodge up patch only, NOT an official solution.

John.

--- linux-2.5.40-orig/drivers/serial/core.c	2002-10-02 15:07:21.000000000 +0100
+++ linux-2.5.40/drivers/serial/core.c	2002-10-02 15:09:38.000000000 +0100
@@ -1604,8 +1604,6 @@
 	return retval;
 }
 
-#ifdef CONFIG_PROC_FS
-
 static const char *uart_type(struct uart_port *port)
 {
 	const char *str = NULL;
@@ -1708,7 +1706,6 @@
 	*start = page + (off - begin);
 	return (count < begin + len - off) ? count : (begin + len - off);
 }
-#endif
 
 #ifdef CONFIG_SERIAL_CORE_CONSOLE
 /*

Re: [PATCH] Bodge up serial support in 2.5.40

[DevilKin]

On Wednesday 02 October 2002 18:36, jbradford@dial.pipex.com wrote:
> Standard 8250/16550 UART support is broken in 2.5.40, and I needed it, so
> following a bit of advice from Russell King, I've prepared this patch.
>

Actually, they work fine in 2.5.40. Well, my serial mouse works fine. So i 
guess the serial port must work fine too.

DK
-- 
Living your life is a task so difficult, it has never been attempted
before.

Re: [PATCH] Bodge up serial support in 2.5.40

[jbradford]

> > > > Standard 8250/16550 UART support is broken in 2.5.40, and I needed it,
> > > > so following a bit of advice from Russell King, I've prepared this
> > > > patch.
> > >
> > > Actually, they work fine in 2.5.40. Well, my serial mouse works fine. So
> > > i guess the serial port must work fine too.
> >
> > Hmmm, that's odd, do you not have proc enabled?  I think that it only
> > breaks if you have proc enabled, which I assumed most people do? 
> > Strange...
> 
> No, proc FS is enabled here.

Really weird, I couldn't get it to compile, it kept failing:

http://www.uwsg.iu.edu/hypermail/linux/kernel/0209.3/1906.html

John.

Re: [PATCH] Bodge up serial support in 2.5.40

[Russell King]

On Wed, Oct 02, 2002 at 06:37:38PM +0200, DevilKin wrote:
> On Wednesday 02 October 2002 18:36, jbradford@dial.pipex.com wrote:
> > Standard 8250/16550 UART support is broken in 2.5.40, and I needed it, so
> > following a bit of advice from Russell King, I've prepared this patch.
> >
> 
> Actually, they work fine in 2.5.40. Well, my serial mouse works fine. So i 
> guess the serial port must work fine too.

Its certain compilation options that mess it up atm.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html