From: Greg KH <greg@kroah.com>
To: Kevin Corry <corryk@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, evms-devel@lists.sourceforge.net
Subject: Re: EVMS Submission for 2.5
Date: Thu, 3 Oct 2002 16:07:28 -0700 [thread overview]
Message-ID: <20021003230728.GF2289@kroah.com> (raw)
In-Reply-To: <02100316563708.05904@boiler>
On Thu, Oct 03, 2002 at 04:56:37PM -0500, Kevin Corry wrote:
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/evms/runtime/linux-2.5/
Heh, looks like you ran the thing through Lindent without looking at the
output. Lindent is a great place to start, but it does generate lines
like the following which you will probably want to fix up by hand
(unless you really want to try to maintain things like this...)
volume_group->
volume_list[AIXppent->
lv_index -
1]->
le_to_pe_map_mir1
[le_number].
pe_sector_offset = offset;
oh, here's another one that's even messier:
volume_group->
volume_list
[AIXppent->
lv_index -
1]->
le_to_pe_map_mir2
[le_number].
pe_sector_offset =
offset;
You also have a number of local variables that use InterCaps.
But, 80 column rants aside, the code looks much better, thank you for
cleaning it up.
thanks,
greg k-h
next prev parent reply other threads:[~2002-10-03 23:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-02 21:33 EVMS Submission for 2.5 Kevin Corry
2002-10-02 22:14 ` Alexander Viro
2002-10-02 22:03 ` Kevin Corry
2002-10-02 23:02 ` Alexander Viro
2002-10-03 13:04 ` Kevin Corry
2002-10-03 14:51 ` Alexander Viro
2002-10-03 14:53 ` Kevin Corry
2002-10-03 15:37 ` Alexander Viro
2002-10-03 16:13 ` Greg KH
2002-10-03 16:21 ` Alexander Viro
2002-10-03 16:30 ` Greg KH
2002-10-03 17:00 ` David Lang
2002-10-03 17:27 ` Greg KH
2002-10-03 19:52 ` [Evms-devel] " Oliver Neukum
2002-10-03 21:37 ` Greg KH
2002-10-03 21:02 ` Oliver Neukum
2002-10-03 22:56 ` Greg KH
2002-10-03 23:03 ` Alexander Viro
2002-10-04 8:07 ` Oliver Neukum
2002-10-05 0:06 ` Greg KH
2002-10-03 16:55 ` Patrick Mochel
2002-10-03 19:24 ` Linus Torvalds
2002-10-02 22:27 ` Shawn
2002-10-02 22:19 ` Shawn
2002-10-02 22:43 ` Greg KH
2002-10-03 12:13 ` Kevin Corry
2002-10-03 16:23 ` Greg KH
2002-10-03 16:51 ` Linus Torvalds
2002-10-03 21:56 ` Kevin Corry
2002-10-03 23:07 ` Greg KH [this message]
2002-10-04 0:39 ` Kevin Corry
2002-10-04 13:06 ` Alan Cox
2002-10-04 13:07 ` [Evms-devel] " Kevin Corry
2002-10-04 17:29 ` Kai Henningsen
2002-10-03 14:32 ` Christoph Hellwig
2002-10-03 14:59 ` [Evms-devel] " Michael Clark
2002-10-03 15:08 ` Christoph Hellwig
2002-10-03 15:03 ` Shawn
2002-10-03 15:31 ` Christoph Hellwig
2002-10-03 15:41 ` [Evms-devel] " Mike Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021003230728.GF2289@kroah.com \
--to=greg@kroah.com \
--cc=corryk@us.ibm.com \
--cc=evms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox