public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] pcibios_* removals for 2.5.40
Date: Fri, 4 Oct 2002 13:51:21 -0700	[thread overview]
Message-ID: <20021004205121.GA8346@kroah.com> (raw)
In-Reply-To: <20021004165955.GC6978@kroah.com>

Hm, looks like Alan owes me a yummy pizza now...

It wasn't that hard to fix up the remaining drivers that used these
functions, here's some changesets that fix up all of the drivers except
two of them.

Please pull from:  http://linuxusb.bkbits.net/pci-2.5

Here's a summary of the status of these pcibios functions after applying
these changesets:

pcibios_present()
 - shows up in a grep in the following files:
   	drivers/char/ip2main.c
	drivers/net/wan/lmc/lmc_ver.h
	drivers/net/wan/sdladrv.c
	drivers/scsi/gdth.c
	drivers/scsi/megaraid.c
	drivers/scsi/qla1280.c
	drivers/scsi/sym53c8xx.c
	drivers/scsi/sym53c8xx_comm.h
	drivers/scsi/tmscsim.c
	include/linux/compatmac.h
   Every one of these instances are for backwards compatibility with
   older kernel versions and will not be used when building for 2.5

pcibios_find_class()
  - completely gone from the 2.5 tree.

pcibios_find_device()
  - the following drivers use it for when they are compiled for older
    kernels:
	drivers/scsi/sym53c8xx.c
	drivers/scsi/sym53c8xx_comm.h
	drivers/char/ip2main.c
	drivers/char/rio/rio_linux.c
	drivers/char/sx.c
	drivers/net/wan/sdladrv.c
	drivers/scsi/gdth.c
	drivers/scsi/megaraid.c
	drivers/scsi/tmscsim.c
   So these instances are safe.

I did not fix up the following two drivers:
 	drivers/char/rocket.c
		This driver does not build at all right now for 2.5 due
		to cli() and other assorted api changes over time in
		2.5.  Also, the PCI probe logic seems very fragile, and
		I do not want to disturb the current sequence without
		fully knowing what the correct board type and number
		sequence should be.
	drivers/isdn/eicon/lincfg.c
		Again the probe sequence seems touchy, and Kai (the ISDN
		maintainer) said he would fix it up properly once these
		patches were accepted.


So the only thing that is broken after these changesets is one isdn
driver (which will be soon fixed by the maintainer), and the rocket.c
driver, which was broken before these changesets :)

Please apply.

Sorry about the one misleading changeset comment, I couldn't figure out
how to go back and change it, and if you really object to it, I'll
rebuild the tree from scratch with it corrected.

thanks,

greg k-h

p.s. I'll send the changesets that I've added since the last set as patches in
response to this email to lkml for those who want to see them.

 drivers/char/rocket.c          |    2 -
 drivers/net/aironet4500_card.c |   43 +++++++++++------------------------------
 drivers/net/hp100.c            |    4 +--
 drivers/net/tulip/de4x5.c      |    4 +--
 drivers/net/wan/lmc/lmc_main.c |   18 +----------------
 drivers/pci/compat.c           |   42 ----------------------------------------
 drivers/pci/syscall.c          |    2 -
 drivers/sbus/sbus.c            |    2 -
 drivers/scsi/53c7,8xx.c        |   13 ++++--------
 drivers/scsi/inia100.c         |    2 -
 include/linux/pci.h            |   27 +++++++++----------------
 11 files changed, 37 insertions(+), 122 deletions(-)
-----

ChangeSet@1.674.3.6, 2002-10-04 12:49:31-07:00, greg@kroah.com
  PCI: remove pcibios_find_device() from the 53c7,8xx.c SCSI driver

 drivers/scsi/53c7,8xx.c |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)
------

ChangeSet@1.674.3.5, 2002-10-04 11:41:16-07:00, greg@kroah.com
  PCI: remove usages of pcibios_find_class()

 drivers/net/aironet4500_card.c |   43 +++++++++++------------------------------
 drivers/net/wan/lmc/lmc_main.c |   18 +----------------
 2 files changed, 14 insertions(+), 47 deletions(-)
------

ChangeSet@1.674.3.4, 2002-10-04 10:28:07-07:00, greg@kroah.com
  PCI: fixed remaining usages of pcibios_present() that I missed previously.

 drivers/char/rocket.c  |    2 +-
 drivers/sbus/sbus.c    |    2 +-
 drivers/scsi/inia100.c |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
------

ChangeSet@1.674.3.3, 2002-10-03 14:06:24-07:00, greg@kroah.com
  PCI: removed pcibios_present()

 drivers/net/hp100.c       |    4 ++--
 drivers/net/tulip/de4x5.c |    4 ++--
 drivers/pci/compat.c      |    8 --------
 drivers/pci/syscall.c     |    2 +-
 include/linux/pci.h       |   21 ++++++++++-----------
 5 files changed, 15 insertions(+), 24 deletions(-)
------

ChangeSet@1.674.3.2, 2002-10-03 13:45:53-07:00, greg@kroah.com
  PCI: remove pci_find_device()

 drivers/pci/compat.c |   17 -----------------
 include/linux/pci.h  |    3 ---
 2 files changed, 20 deletions(-)
------

ChangeSet@1.674.3.1, 2002-10-03 13:36:51-07:00, greg@kroah.com
  PCI: remove pcibios_find_class()

 drivers/pci/compat.c |   17 -----------------
 include/linux/pci.h  |    3 ---
 2 files changed, 20 deletions(-)
------


  parent reply	other threads:[~2002-10-04 20:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-03 22:40 [BK PATCH] pcibios_* removals for 2.5.40 Greg KH
2002-10-03 22:40 ` Greg KH
2002-10-03 22:41   ` Greg KH
2002-10-03 22:41     ` Greg KH
2002-10-04 16:33 ` Linus Torvalds
2002-10-04 16:53   ` Alan Cox
2002-10-04 17:30     ` Linus Torvalds
2002-10-04 18:01       ` Greg KH
2002-10-04 16:59   ` Greg KH
2002-10-04 17:28     ` Alan Cox
2002-10-04 18:07       ` Arnaldo Carvalho de Melo
2002-10-04 20:51     ` Greg KH [this message]
2002-10-04 20:52       ` Greg KH
2002-10-04 20:53         ` Greg KH
2002-10-04 20:54           ` Greg KH
2002-10-04 21:34             ` Jeff Garzik
2002-10-04 21:52               ` Greg KH
2002-10-04 21:36           ` Jeff Garzik
2002-10-04 21:40         ` Jeff Garzik
2002-10-04 21:53           ` Greg KH
2002-10-04 22:14             ` Russell King
2002-10-04 18:03   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021004205121.GA8346@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox