public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: linux-kernel@vger.kernel.org
Cc: rmk@arm.linux.org.uk
Subject: 2.5.40 serial oops
Date: Fri, 4 Oct 2002 20:36:59 -0700	[thread overview]
Message-ID: <20021005033659.GD21619@holomorphy.com> (raw)

On shutdown, ThinkPad T21's commit this error:

Program received signal SIGSEGV, Segmentation fault.
0x00000000 in ?? ()
(gdb) bt
#0  0x00000000 in ?? ()
#1  0xc01b9eb3 in pci_remove_one (dev=0xc1675c00) at 8250_pci.c:774
#2  0xc01b3a25 in pci_device_remove (dev=0xc1675c50) at pci-driver.c:68
#3  0xc01bdbae in device_shutdown () at power.c:106
#4  0xc0121421 in sys_reboot (magic1=-18751827, magic2=672274793, 
    cmd=1126301404, arg=0x8049960) at sys.c:393
#5  0xc0108a8f in syscall_call () at process.c:685

(gdb) p *priv->board
$1 = {flags = 0, num_ports = 1, base_baud = 115200, uart_offset = 0, 
  reg_shift = 0, init_fn = 0, first_uart_offset = 0}
(gdb) p pci_boards - priv->board
$2 = 0

Against 2.5.40


--- linux-2.5.40/drivers/serial/8250_pci.c.orig	2002-10-04 20:27:50.000000000 -0700
+++ linux-2.5.40/drivers/serial/8250_pci.c	2002-10-04 20:28:02.000000000 -0700
@@ -771,7 +771,8 @@
 		for (i = 0; i < priv->nr; i++)
 			unregister_serial(priv->line[i]);
 
-		priv->board->init_fn(dev, priv->board, 0);
+		if (priv->board->init_fn)
+			priv->board->init_fn(dev, priv->board, 0);
 
 		pci_disable_device(dev);
 

                 reply	other threads:[~2002-10-05  3:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021005033659.GD21619@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox