From: Bart Trojanowski <bart@jukie.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] [2.4.19] fix for fuzzy hash <linux/ghash.h> [Attempt 2]
Date: Sun, 6 Oct 2002 17:01:24 -0400 [thread overview]
Message-ID: <20021006170124.D28201@jukie.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
[ Originally posted on 2002/09/11; I just looked in 2.4.20-pre9 and it
was not there, hence the repost. ]
The DEF_HASH_FUZZY macro allows the user to template their hash; it
takes on a paramter for the hashing-function, namely HASHFN. When used
with a hashing-function named anything other than 'hashfn()', a module
using the kernel's fuzzy hash implementation will not compile.
None of the in-kernel 2.4.x drivers use this primitive (yet) so it's no
wonder no one has spotted it. The patch is very trivial and makes me
think that I am the very first user of the include/linux/ghash.h
hash-table primitive. ;)
Bart.
---
diff -ruN linux-2.4.19/include/linux/ghash.h linux-2.4.19+ghash-fix/include/linux/ghash.h
--- linux-2.4.19/include/linux/ghash.h Wed Sep 11 10:09:57 2002
+++ linux-2.4.19+ghash-fix/include/linux/ghash.h Wed Sep 11 10:12:52 2002
@@ -106,7 +106,7 @@
\
LINKAGE TYPE * find_##NAME##_hash(struct NAME##_table * tbl, KEYTYPE pos)\
{\
- int ix = hashfn(pos);\
+ int ix = HASHFN(pos);\
TYPE * ptr = tbl->hashtable[ix];\
while(ptr && KEYCMP(ptr->KEY, pos))\
ptr = ptr->PTRS.next_hash;\
@@ -206,7 +206,7 @@
\
LINKAGE TYPE * find_##NAME##_hash(struct NAME##_table * tbl, KEYTYPE pos)\
{\
- int ix = hashfn(pos);\
+ int ix = HASHFN(pos);\
TYPE * ptr = tbl->hashtable[ix];\
while(ptr && KEYCMP(ptr->KEY, pos))\
ptr = ptr->PTRS.next_hash;\
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2002-10-06 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-06 21:01 Bart Trojanowski [this message]
2002-10-07 5:22 ` [PATCH] [2.4.19] fix for fuzzy hash <linux/ghash.h> [Attempt 2] Arnaldo Carvalho de Melo
2002-10-10 19:17 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021006170124.D28201@jukie.net \
--to=bart@jukie.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox