Re: [PATCH] hid-input: fix find_next_zero_bit usage

[Vojtech Pavlik <vojtech@suse.cz>]

On Thu, Oct 10, 2002 at 01:50:02AM -0300, Arnaldo Carvalho de Melo wrote:

> Hi Vojtech,
> 
> 	Please apply this changeset, comments below, and this has to be
> applied to both 2.4 and 2.5.
> 
> - Arnaldo

Ok, added it to my repository. Greg, will you please take care of 2.4?

> 
> You can import this changeset into BK by piping this whole message to:
> '| bk receive [path to repository]' or apply the patch as usual.
> 
> ===================================================================
> 
> 
> ChangeSet@1.747, 2002-10-10 01:22:17-03:00, acme@dhcp197.conectiva
>   o hid-input: fix find_next_zero_bit usage
>   
>   It was swapping the parameters, using the bitfield size for the
>   offset and the offset for the bitfield size. With this the mouse
>   buttons in my wireless USB keyboard finally works 8) 2.4 has the
>   same problem.
> 
> 
>  hid-input.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff -Nru a/drivers/usb/input/hid-input.c b/drivers/usb/input/hid-input.c
> --- a/drivers/usb/input/hid-input.c	Thu Oct 10 01:26:11 2002
> +++ b/drivers/usb/input/hid-input.c	Thu Oct 10 01:26:11 2002
> @@ -348,7 +348,7 @@
>  	set_bit(usage->type, input->evbit);
>  
>  	while (usage->code <= max && test_and_set_bit(usage->code, bit)) {
> -		usage->code = find_next_zero_bit(bit, max + 1, usage->code);
> +		usage->code = find_next_zero_bit(bit, usage->code, max + 1);
>  	}
>  
>  	if (usage->code > max) return;
> 
> ===================================================================

-- 
Vojtech Pavlik
SuSE Labs