Re: 2.5.41-mm3

Re: 2.5.41-mm3

[Ed Tomlinson]

Hi,

I get this opps just after boot - the box was sitting waiting for me to login 
and start X.  Nothing unsual in the boot log - same config I have been using

-------------
oscar login: Unable to handle kernel paging request at virtual address 8978408f
 printing eip:
c012b364
*pde = 00000000
Oops: 0002
af_packet snd-seq-midi snd-seq-oss snd-seq-midi-event snd-seq snd-pcm-oss snd-mixer-oss snd-cs46xx snd-pcm snd-timer snd-rawmidi snd-seq-device snd-ac97-codec snd soundcore gameport softdog matroxfb_base matroxfb_g450 matroxfb_DAC1064 g450_pll matroxfb_accel matroxfb_misc fbcon-cfb16 fbcon-cfb8 fbcon-cfb24 fbcon-cfb32 mga agpgart pppoe pppox ipchains msdos fat sd_mod floppy dummy bsd_comp ppp_generic slhc parport_pc lp parport ipip smbfs binfmt_aout autofs4 cdrom via-rhine mii tulip crc32 usb-storage scsi_mod hid pl2303 usbserial  
CPU:    0
EIP:    0060:[<c012b364>]    Not tainted
EFLAGS: 00010012
EIP is at free_block+0x50/0xe4
eax: 8978408b   ebx: dc2ad240   ecx: dc2bd000   edx: 558ba445
esi: dffec21c   edi: 00000004   ebp: dffec228   esp: c0295eec
ds: 0068   es: 0068   ss: 0068
Process swapper (pid: 0, threadinfo=c0294000 task=c02596c0)
Stack: 00000008 c173a400 c173a410 dffec21c c0295f18 c173a420 c012b86e dffec21c 
       c173a410 00000008 c0353b1c c0294000 c02ab480 00000000 dffec408 c0294000 
       dffec288 c011b6ef 00000000 00000000 c032fc60 fffffffe c032fc60 c012b7ec 
Call Trace:
 [<c012b86e>] reap_timer_fnc+0x82/0x478
 [<c011b6ef>] run_timer_tasklet+0xe7/0x130
 [<c012b7ec>] reap_timer_fnc+0x0/0x478
 [<c01187e8>] tasklet_hi_action+0x3c/0x60
 [<c011860b>] do_softirq+0x5b/0xac
 [<c0108560>] do_IRQ+0xfc/0x114
 [<c01052e0>] default_idle+0x0/0x28
 [<c0105000>] stext+0x0/0x50
 [<c01070e8>] common_interrupt+0x18/0x20
 [<c01052e0>] default_idle+0x0/0x28
 [<c0105000>] stext+0x0/0x50
 [<c0105303>] default_idle+0x23/0x28
 [<c0105374>] cpu_idle+0x28/0x38
 [<c010504d>] stext+0x4d/0x50

Code: 89 50 04 89 02 2b 59 0c 89 d8 31 d2 f7 76 30 89 c3 8b 41 14 
 <0>Kernel panic: Aiee, killing interrupt handler!
In interrupt handler - not syncing

Hope this helps,
Ed Tomlinson
 

Re: 2.5.41-mm3

[Ed Tomlinson]

On October 11, 2002 08:37 am, Ed Tomlinson wrote:
> Hi,
>
> I get this opps just after boot - the box was sitting waiting for me to
> login and start X.  Nothing unsual in the boot log - same config I have
> been using

Note that 2.5.42-mm2 is starting correctly.  Not sure what happened here..

Ed

PS. email problems at this end...


> -------------
> oscar login: Unable to handle kernel paging request at virtual address
> 8978408f printing eip:
> c012b364
> *pde = 00000000
> Oops: 0002
> af_packet snd-seq-midi snd-seq-oss snd-seq-midi-event snd-seq snd-pcm-oss
> snd-mixer-oss snd-cs46xx snd-pcm snd-timer snd-rawmidi snd-seq-device
> snd-ac97-codec snd soundcore gameport softdog matroxfb_base matroxfb_g450
> matroxfb_DAC1064 g450_pll matroxfb_accel matroxfb_misc fbcon-cfb16
> fbcon-cfb8 fbcon-cfb24 fbcon-cfb32 mga agpgart pppoe pppox ipchains msdos
> fat sd_mod floppy dummy bsd_comp ppp_generic slhc parport_pc lp parport
> ipip smbfs binfmt_aout autofs4 cdrom via-rhine mii tulip crc32 usb-storage
> scsi_mod hid pl2303 usbserial CPU:    0
> EIP:    0060:[<c012b364>]    Not tainted
> EFLAGS: 00010012
> EIP is at free_block+0x50/0xe4
> eax: 8978408b   ebx: dc2ad240   ecx: dc2bd000   edx: 558ba445
> esi: dffec21c   edi: 00000004   ebp: dffec228   esp: c0295eec
> ds: 0068   es: 0068   ss: 0068
> Process swapper (pid: 0, threadinfo=c0294000 task=c02596c0)
> Stack: 00000008 c173a400 c173a410 dffec21c c0295f18 c173a420 c012b86e
> dffec21c c173a410 00000008 c0353b1c c0294000 c02ab480 00000000 dffec408
> c0294000 dffec288 c011b6ef 00000000 00000000 c032fc60 fffffffe c032fc60
> c012b7ec Call Trace:
>  [<c012b86e>] reap_timer_fnc+0x82/0x478
>  [<c011b6ef>] run_timer_tasklet+0xe7/0x130
>  [<c012b7ec>] reap_timer_fnc+0x0/0x478
>  [<c01187e8>] tasklet_hi_action+0x3c/0x60
>  [<c011860b>] do_softirq+0x5b/0xac
>  [<c0108560>] do_IRQ+0xfc/0x114
>  [<c01052e0>] default_idle+0x0/0x28
>  [<c0105000>] stext+0x0/0x50
>  [<c01070e8>] common_interrupt+0x18/0x20
>  [<c01052e0>] default_idle+0x0/0x28
>  [<c0105000>] stext+0x0/0x50
>  [<c0105303>] default_idle+0x23/0x28
>  [<c0105374>] cpu_idle+0x28/0x38
>  [<c010504d>] stext+0x4d/0x50
>
> Code: 89 50 04 89 02 2b 59 0c 89 d8 31 d2 f7 76 30 89 c3 8b 41 14
>  <0>Kernel panic: Aiee, killing interrupt handler!
> In interrupt handler - not syncing
>
> Hope this helps,
> Ed Tomlinson

2.5.41+ shutdown problems

[Ed Tomlinson]

Hi,

All version of 2.5.41-mm and 2.5.41-bk are giving me an oops like the
following during shutdown:

Sending all processes the KILL signal... done.
Saving random seed... done.
Unmounting remote filesystems... done.
Deconfiguring network interfaces... done.
Deactivating swap... done.
Unmounting local filesystems... done.
raidtools2 init script failed; RAID drivers not available.
Rebooting...  printing eip:
c015e0fe
*pde = 00000000
Oops: 0002
isofs ide-cd af_packet gameport softdog matroxfb_base matroxfb_g450 matroxfb_DAC1064 g450_pll matroxfb_acc
el fbcon-cfb16 fbcon-cfb8 fbcon-cfb24 fbcon-cfb32 matroxfb_misc mga agpgart pppoe pppox ipchains msdos fat
 sd_mod floppy dummy bsd_comp ppp_generic slhc parport_pc lp parport ipip smbfs nls_cp850 nls_cp437 nfs lo
ckd sunrpc binfmt_aout autofs4 cdrom via-rhine mii tulip crc32 scsi_mod
CPU:    0
EIP:    0060:[<c015e0fe>]    Not tainted
EFLAGS: 00010246
EIP is at driverfs_remove_file+0x22/0x80
eax: 00000001   ebx: 00000000   ecx: 0000005c   edx: 00000001
esi: 0000005c   edi: c1796ef0   ebp: 00000001   esp: dcf25e18
ds: 0068   es: 0068   ss: 0068
Process reboot (pid: 30446, threadinfo=dcf24000 task=d0467920)
Stack: c0226736 0000007e c1796e50 00000000 c1796e00 c0196369 c1796ef0 c0226581
       c1796e50 c1796e50 c015ca35 c1796e50 c025d25c c1796e00 c1796e00 00000001
       c015cf93 c1796e00 c03701ec c01bce06 c1796e00 c03701ec 00000001 c01ba4d5
Call Trace:
 [<c0196369>] device_remove_file+0x21/0x2c
 [<c015ca35>] driverfs_remove_partitions+0x71/0x94
 [<c015cf93>] del_gendisk+0xb/0x3c
 [<c01bce06>] idedisk_cleanup+0x5e/0x70
 [<c01ba4d5>] ide_notify_reboot+0x8d/0xb8
 [<c011d76a>] notifier_call_chain+0x1e/0x38
 [<c011dc0e>] sys_reboot+0xd2/0x2a4
 [<c012435d>] do_no_page+0x219/0x288
 [<c012444c>] handle_mm_fault+0x80/0x120
 [<c01db98b>] sock_destroy_inode+0x13/0x70
 [<c014bdc2>] destroy_inode+0x3a/0x64
 [<c014ca1f>] generic_forget_inode+0xf7/0x100
 [<c014ca46>] generic_drop_inode+0x1e/0x24
 [<c014caad>] iput+0x61/0x68
 [<c014a5b6>] dput+0x1a/0x1b8
 [<c01393d6>] __fput+0xba/0xdc
 [<c013931b>] fput+0x13/0x14
 [<c0137c65>] filp_close+0x99/0xa4
 [<c0137cc8>] sys_close+0x58/0x80
 [<c0106ef7>] syscall_call+0x7/0xb

Code: ff 4b 5c 0f 88 a3 01 00 00 83 c4 08 ff 74 24 14 ff 77 04 e8
 /etc/rc6.d/S90reboot: line 11: 30446 Segmentation fault      reboot -d -f -i
Give root password for maintenance
(or type Control-D for normal startup):

Ideas?
Ed Tomlinson

Re: 2.5.41+ shutdown problems

[Ed Tomlinson]

On October 11, 2002 08:40 am, Ed Tomlinson wrote:

This is happening with 2.5.42-mm2 too (tunneling to another smtp server...)

> Hi,
>
> All version of 2.5.41-mm and 2.5.41-bk are giving me an oops like the
> following during shutdown:
>
> Sending all processes the KILL signal... done.
> Saving random seed... done.
> Unmounting remote filesystems... done.
> Deconfiguring network interfaces... done.
> Deactivating swap... done.
> Unmounting local filesystems... done.
> raidtools2 init script failed; RAID drivers not available.
> Rebooting...  printing eip:
> c015e0fe
> *pde = 00000000
> Oops: 0002
> isofs ide-cd af_packet gameport softdog matroxfb_base matroxfb_g450
> matroxfb_DAC1064 g450_pll matroxfb_acc el fbcon-cfb16 fbcon-cfb8
> fbcon-cfb24 fbcon-cfb32 matroxfb_misc mga agpgart pppoe pppox ipchains
> msdos fat sd_mod floppy dummy bsd_comp ppp_generic slhc parport_pc lp
> parport ipip smbfs nls_cp850 nls_cp437 nfs lo ckd sunrpc binfmt_aout
> autofs4 cdrom via-rhine mii tulip crc32 scsi_mod CPU:    0
> EIP:    0060:[<c015e0fe>]    Not tainted
> EFLAGS: 00010246
> EIP is at driverfs_remove_file+0x22/0x80
> eax: 00000001   ebx: 00000000   ecx: 0000005c   edx: 00000001
> esi: 0000005c   edi: c1796ef0   ebp: 00000001   esp: dcf25e18
> ds: 0068   es: 0068   ss: 0068
> Process reboot (pid: 30446, threadinfo=dcf24000 task=d0467920)
> Stack: c0226736 0000007e c1796e50 00000000 c1796e00 c0196369 c1796ef0
> c0226581 c1796e50 c1796e50 c015ca35 c1796e50 c025d25c c1796e00 c1796e00
> 00000001 c015cf93 c1796e00 c03701ec c01bce06 c1796e00 c03701ec 00000001
> c01ba4d5 Call Trace:
>  [<c0196369>] device_remove_file+0x21/0x2c
>  [<c015ca35>] driverfs_remove_partitions+0x71/0x94
>  [<c015cf93>] del_gendisk+0xb/0x3c
>  [<c01bce06>] idedisk_cleanup+0x5e/0x70
>  [<c01ba4d5>] ide_notify_reboot+0x8d/0xb8
>  [<c011d76a>] notifier_call_chain+0x1e/0x38
>  [<c011dc0e>] sys_reboot+0xd2/0x2a4
>  [<c012435d>] do_no_page+0x219/0x288
>  [<c012444c>] handle_mm_fault+0x80/0x120
>  [<c01db98b>] sock_destroy_inode+0x13/0x70
>  [<c014bdc2>] destroy_inode+0x3a/0x64
>  [<c014ca1f>] generic_forget_inode+0xf7/0x100
>  [<c014ca46>] generic_drop_inode+0x1e/0x24
>  [<c014caad>] iput+0x61/0x68
>  [<c014a5b6>] dput+0x1a/0x1b8
>  [<c01393d6>] __fput+0xba/0xdc
>  [<c013931b>] fput+0x13/0x14
>  [<c0137c65>] filp_close+0x99/0xa4
>  [<c0137cc8>] sys_close+0x58/0x80
>  [<c0106ef7>] syscall_call+0x7/0xb
>
> Code: ff 4b 5c 0f 88 a3 01 00 00 83 c4 08 ff 74 24 14 ff 77 04 e8
>  /etc/rc6.d/S90reboot: line 11: 30446 Segmentation fault      reboot -d -f
> -i Give root password for maintenance
> (or type Control-D for normal startup):
>
> Ideas?
> Ed Tomlinson

Re: 2.5.41+ shutdown problems

[Bjoern A. Zeeb]

On Fri, 11 Oct 2002, Ed Tomlinson wrote:

> All version of 2.5.41-mm and 2.5.41-bk are giving me an oops like the
> following during shutdown:

[snip]

patch was sent to lkml and is fixed in later bk resp 2.5.42 I guess.
Just do a pull and get the next one ;-)))

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
56 69 73 69 74				http://www.zabbadoz.net/

2.5.x opps stopping serial

[Ed Tomlinson]

Hi,

I have been seeing this during shutdown ever since I started using 2.5.  Figured
I really should report it...   There are three serial ports.  One for a serial console,
the second for a backUPS ups, the third for a (real) modem.  Dist is debian sid.

Saving state of known serial devices... Unable to handle kernel NULL pointer dereference at virtual addres
s 00000114
 printing eip:
c0191f73
*pde = 00000000
Oops: 0000
af_packet snd-seq-midi snd-seq-oss snd-seq-midi-event snd-seq snd-pcm-oss snd-mixer-oss snd-cs46xx snd-pcm
 snd-timer snd-rawmidi snd-seq-device snd-ac97-codec snd soundcore gameport softdog matroxfb_base matroxfb
_g450 matroxfb_DAC1064 g450_pll matroxfb_accel fbcon-cfb24 fbcon-cfb8 fbcon-cfb32 fbcon-cfb16 matroxfb_mis
c mga agpgart pppoe pppox ipchains msdos fat sd_mod floppy dummy bsd_comp ppp_generic slhc parport_pc lp p
arport ipip smbfs nls_cp850 nls_cp437 nfs lockd sunrpc binfmt_aout autofs4 cdrom via-rhine mii tulip crc32
 usb-storage scsi_mod pl2303 usbserial hid
CPU:    0
EIP:    0060:[<c0191f73>]    Not tainted
EFLAGS: 00010246
EIP is at uart_block_til_ready+0x15b/0x1a4
eax: 00000000   ebx: d9cd4000   ecx: dffe381c   edx: c17a5114
esi: d9cd5e84   edi: 00000202   ebp: c17a50c0   esp: d9cd5e58
ds: 0068   es: 0068   ss: 0068
Process bkupsd (pid: 1096, threadinfo=d9cd4000 task=dc75a160)
Stack: c0284800 d9b75000 c17a50c0 00000000 c0356804 dffe381c 00000000 dc75a160
       c0110868 00000000 00000000 00000000 dc75a160 c0110868 c17a5114 c17a5114
       c0192269 d9e64d20 c17a50c0 00000000 00000100 00000000 dec0b3b4 d9cd4000
Call Trace:
 [<c0110868>] default_wake_function+0x0/0x2c
 [<c0110868>] default_wake_function+0x0/0x2c
 [<c0192269>] uart_open+0x1d9/0x220
 [<c0199d72>] tty_open+0x1e6/0x39c
 [<c0199da3>] tty_open+0x217/0x39c
 [<c0139759>] get_chrfops+0xa1/0x164
 [<c0139a03>] chrdev_open+0x5b/0x94
 [<c01382f9>] dentry_open+0xb9/0x16c
 [<c0138237>] filp_open+0x43/0x4c
 [<c01385d8>] sys_open+0x34/0x70
 [<c0106ef7>] syscall_call+0x7/0xb

Code: f6 80 14 01 00 00 02 75 34 8b 44 24 44 50 e8 6a 6b 00 00 83
 backing up serial.conf done.

Ideas?
Ed Tomlinson

Re: 2.5.x opps stopping serial

[Ed Tomlinson]

On October 11, 2002 08:45 am, Ed Tomlinson wrote:

Still happening with 2.5.42-mm2 (email problems - using different smtp server)

> Hi,
>
> I have been seeing this during shutdown ever since I started using 2.5. 
> Figured I really should report it...   There are three serial ports.  One
> for a serial console, the second for a backUPS ups, the third for a (real)
> modem.  Dist is debian sid.
>
> Saving state of known serial devices... Unable to handle kernel NULL
> pointer dereference at virtual addres s 00000114
>  printing eip:
> c0191f73
> *pde = 00000000
> Oops: 0000
> af_packet snd-seq-midi snd-seq-oss snd-seq-midi-event snd-seq snd-pcm-oss
> snd-mixer-oss snd-cs46xx snd-pcm snd-timer snd-rawmidi snd-seq-device
> snd-ac97-codec snd soundcore gameport softdog matroxfb_base matroxfb _g450
> matroxfb_DAC1064 g450_pll matroxfb_accel fbcon-cfb24 fbcon-cfb8 fbcon-cfb32
> fbcon-cfb16 matroxfb_mis c mga agpgart pppoe pppox ipchains msdos fat
> sd_mod floppy dummy bsd_comp ppp_generic slhc parport_pc lp p arport ipip
> smbfs nls_cp850 nls_cp437 nfs lockd sunrpc binfmt_aout autofs4 cdrom
> via-rhine mii tulip crc32 usb-storage scsi_mod pl2303 usbserial hid
> CPU:    0
> EIP:    0060:[<c0191f73>]    Not tainted
> EFLAGS: 00010246
> EIP is at uart_block_til_ready+0x15b/0x1a4
> eax: 00000000   ebx: d9cd4000   ecx: dffe381c   edx: c17a5114
> esi: d9cd5e84   edi: 00000202   ebp: c17a50c0   esp: d9cd5e58
> ds: 0068   es: 0068   ss: 0068
> Process bkupsd (pid: 1096, threadinfo=d9cd4000 task=dc75a160)
> Stack: c0284800 d9b75000 c17a50c0 00000000 c0356804 dffe381c 00000000
> dc75a160 c0110868 00000000 00000000 00000000 dc75a160 c0110868 c17a5114
> c17a5114 c0192269 d9e64d20 c17a50c0 00000000 00000100 00000000 dec0b3b4
> d9cd4000 Call Trace:
>  [<c0110868>] default_wake_function+0x0/0x2c
>  [<c0110868>] default_wake_function+0x0/0x2c
>  [<c0192269>] uart_open+0x1d9/0x220
>  [<c0199d72>] tty_open+0x1e6/0x39c
>  [<c0199da3>] tty_open+0x217/0x39c
>  [<c0139759>] get_chrfops+0xa1/0x164
>  [<c0139a03>] chrdev_open+0x5b/0x94
>  [<c01382f9>] dentry_open+0xb9/0x16c
>  [<c0138237>] filp_open+0x43/0x4c
>  [<c01385d8>] sys_open+0x34/0x70
>  [<c0106ef7>] syscall_call+0x7/0xb
>
> Code: f6 80 14 01 00 00 02 75 34 8b 44 24 44 50 e8 6a 6b 00 00 83
>  backing up serial.conf done.
>
> Ideas?
> Ed Tomlinson

Re: 2.5.x opps stopping serial

[Paul Larson]

On Fri, 2002-10-11 at 07:45, Ed Tomlinson wrote:
> Hi,
> 
> I have been seeing this during shutdown ever since I started using 2.5.  Figured
> I really should report it...   There are three serial ports.  One for a serial console,
> the second for a backUPS ups, the third for a (real) modem.  Dist is debian sid.
> 
> Saving state of known serial devices... Unable to handle kernel NULL pointer dereference at virtual addres
Looks like it might be similar to one I saw with smatch recently.  There
are several places in core.c that check info->tty before dereferencing
it, but others that don't.  I don't think this will fix the one you are
seeing, but if it's easily reproducible you could try doing something
similar in uart_block_til_ready.

--- linux-2.5/drivers/serial/core.c	Wed Oct  9 13:45:11 2002
+++ linux-corefix/drivers/serial/core.c	Wed Oct  9 13:50:09 2002
@@ -207,7 +207,7 @@
 			 * Setup the RTS and DTR signals once the
 			 * port is open and ready to respond.
 			 */
-			if (info->tty->termios->c_cflag & CBAUD)
+			if (info->tty && (info->tty->termios->c_cflag & CBAUD))
 				uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
 		}
 
Thanks,
Paul Larson

Re: 2.5.x opps stopping serial

[Ed Tomlinson]

On October 15, 2002 06:07 pm, Russell King wrote:
> On Fri, Oct 11, 2002 at 08:45:24AM -0400, Ed Tomlinson wrote:
> > I have been seeing this during shutdown ever since I started using 2.5.
> > Figured I really should report it...   There are three serial ports.
> > One for a serial console, the second for a backUPS ups, the third for
> > a (real) modem.  Dist is debian sid.
>
> Can you try this patch please?  It prevents the hangup code from
> setting info->tty to NULL while we're trying to open the port.

This fails to fix the problem (2.5.42-mm2) patch applied...

Oct 15 21:15:39 oscar -- MARK --
Oct 15 21:26:32 oscar kernel:  printing eip:
Oct 15 21:26:32 oscar kernel: c0192b23
Oct 15 21:26:32 oscar kernel: Oops: 0000
Oct 15 21:26:32 oscar kernel: af_packet snd-seq-midi snd-seq-oss snd-seq-midi-event snd-seq snd-pcm-oss snd-mixer-oss sn
d-cs46xx snd-pcm snd-timer snd-rawmidi snd-seq-device snd-ac97-codec snd soundcore gameport softdog matroxfb_base matrox
fb_g450 matroxfb_DAC1064 g450_pll matroxfb_accel matroxfb_misc fbcon-cfb16 fbcon-cfb8 fbcon-cfb24 fbcon-cfb32 mga agpgar
t pppoe pppox ipchains msdos fat sd_mod floppy dummy bsd_comp ppp_generic slhc parport_pc lp parport ipip smbfs nls_cp85
0 nls_cp437 binfmt_aout autofs4 cdrom via-rhine mii tulip crc32 usb-storage scsi_mod pl2303 usbserial hid
Oct 15 21:26:32 oscar kernel: CPU:    0
Oct 15 21:26:32 oscar kernel: EIP:    0060:[uart_open+147/544]    Not tainted
Oct 15 21:26:32 oscar kernel: EFLAGS: 00010246
Oct 15 21:26:32 oscar kernel: EIP is at uart_block_til_ready+0x15b/0x1a4
Oct 15 21:26:32 oscar kernel: eax: 00000000   ebx: da040000   ecx: dffe381c   edx: c15da294
Oct 15 21:26:32 oscar kernel: esi: da041e84   edi: 00000202   ebp: c15da240   esp: da041e58
Oct 15 21:26:32 oscar kernel: ds: 0068   es: 0068   ss: 0068
Oct 15 21:26:32 oscar kernel: Process bkupsd (pid: 897, threadinfo=da040000 task=da316dc0)
Oct 15 21:26:32 oscar kernel: Stack: c02863c0 da084000 c15da240 00000000 c0358724 dffe381c 00000000 da316dc0
Oct 15 21:26:32 oscar kernel:        c0110ea8 00000000 00000000 00000000 da316dc0 c0110ea8 c15da294 c15da294
Oct 15 21:26:32 oscar kernel:        c0192e19 da3018c0 c15da240 00000000 00000100 00000000 deffd214 da040000
Oct 15 21:26:32 oscar kernel: Call Trace:
Oct 15 21:26:32 oscar kernel:  [default_wake_function+0/44] default_wake_function+0x0/0x2c
Oct 15 21:26:32 oscar kernel:  [default_wake_function+0/44] default_wake_function+0x0/0x2c
Oct 15 21:26:32 oscar kernel:  [uart_line_info+325/804] uart_open+0x1d9/0x220
Oct 15 21:26:32 oscar kernel:  [tty_open+918/924] tty_open+0x1e6/0x39c
Oct 15 21:26:32 oscar kernel:  [tty_release+43/92] tty_open+0x217/0x39c
Oct 15 21:26:32 oscar kernel:  [unregister_chrdev+1/176] get_chrfops+0xa1/0x164
Oct 15 21:26:32 oscar kernel:  [get_empty_filp+83/420] chrdev_open+0x5b/0x94
Oct 15 21:26:32 oscar kernel:  [get_unused_fd+237/392] dentry_open+0xb9/0x16c
Oct 15 21:26:32 oscar kernel:  [get_unused_fd+43/392] filp_open+0x43/0x4c
Oct 15 21:26:32 oscar kernel:  [sys_vhangup+40/48] sys_open+0x34/0x70
Oct 15 21:26:32 oscar kernel:  [syscall_call+7/11] syscall_call+0x7/0xb
Oct 15 21:26:32 oscar kernel:
Oct 15 21:26:32 oscar kernel: Code: f6 80 14 01 00 00 02 75 34 8b 44 24 44 50 e8 aa 6b 00 00 83
Oct 15 21:26:38 oscar pppd[646]: Terminating on signal 15.

Ideas?
Ed Tomlinson

>
> --- orig/drivers/serial/core.c	Sat Oct 12 10:01:59 2002
> +++ linux/drivers/serial/core.c	Tue Oct 15 23:00:50 2002
> @@ -22,7 +22,7 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 
> USA *
> - *  $Id: core.c,v 1.100 2002/07/28 10:03:28 rmk Exp $
> + *  $Id: core.c,v 1.106 2002/08/02 12:55:07 rmk Exp $
>   *
>   */
>  #include <linux/config.h>
> @@ -207,7 +207,7 @@
>  			 * Setup the RTS and DTR signals once the
>  			 * port is open and ready to respond.
>  			 */
> -			if (info->tty->termios->c_cflag & CBAUD)
> +			if (info->tty && info->tty->termios->c_cflag & CBAUD)
>  				uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
>  		}
>
> @@ -1196,13 +1271,13 @@
>  	}
>  	down(&port_sem);
>  	uart_shutdown(info);
> -	up(&port_sem);
>  	uart_flush_buffer(tty);
>  	if (tty->ldisc.flush_buffer)
>  		tty->ldisc.flush_buffer(tty);
>  	tty->closing = 0;
>  	info->event = 0;
>  	info->tty = NULL;
> +	up(&port_sem);
>  	if (info->blocked_open) {
>  		if (info->state->close_delay) {
>  			set_current_state(TASK_INTERRUPTIBLE);
> @@ -1357,6 +1432,10 @@
>  	}
>  }
>
> +/*
> + * Block the open until the port is ready.  We must be called with
> + * port_sem held.
> + */
>  static int
>  uart_block_til_ready(struct file *filp, struct uart_info *info)
>  {
> @@ -1374,7 +1453,7 @@
>  		/*
>  		 * If we have been hung up, tell userspace/restart open.
>  		 */
> -		if (tty_hung_up_p(filp))
> +		if (tty_hung_up_p(filp) || info->tty == NULL)
>  			break;
>
>  		/*
> @@ -1422,7 +1501,9 @@
>  			break;
>
>  	 wait:
> +		up(&port_sem);
>  		schedule();
> +		down(&port_sem);
>
>  		if (signal_pending(current))
>  			break;
> @@ -1436,10 +1517,7 @@
>  	if (signal_pending(current))
>  		return -ERESTARTSYS;
>
> -	if (info->tty->flags & (1 << TTY_IO_ERROR))
> -		return 0;
> -
> -	if (tty_hung_up_p(filp) || !(info->flags & UIF_INITIALIZED))
> +	if (!info->tty || tty_hung_up_p(filp))
>  		return (port->flags & UPF_HUP_NOTIFY) ?
>  			-EAGAIN : -ERESTARTSYS;
>
> @@ -1451,7 +1529,6 @@
>  	struct uart_state *state = drv->state + line;
>  	struct uart_info *info = NULL;
>
> -	down(&port_sem);
>  	if (!state->port)
>  		goto out;
>
> @@ -1480,7 +1557,6 @@
>  	}
>
>   out:
> -	up(&port_sem);
>  	return info;
>  }
>
> @@ -1527,10 +1603,18 @@
>  	/*
>  	 * FIXME: This one isn't fun.  We can't guarantee that the tty isn't
>  	 * already in open, nor can we guarantee the state of tty->driver_data
> +	 *
> +	 * We take the semaphore here to guarantee that we won't be re-entered
> +	 * while allocating the info structure, or while we request any IRQs
> +	 * that the driver may need.  This also has the nice side-effect that
> +	 * it delays the action of uart_hangup, so we can guarantee that
> +	 * info->tty will always contain something reasonable.
>  	 */
> +	down(&port_sem);
>  	info = uart_get(drv, line);
>  	retval = -ENOMEM;
>  	if (!info) {
> +		up(&port_sem);
>  		if (tty->driver_data)
>  			goto fail;
>  		else
> @@ -1543,6 +1627,7 @@
>  	 * Any failures from here onwards should not touch the count.
>  	 */
>  	tty->driver_data = info;
> +	tty->alt_speed = 0;
>  	info->tty = tty;
>  	info->tty->low_latency = (info->port->flags & UPF_LOW_LATENCY) ? 1 : 0;
>
> @@ -1550,6 +1635,7 @@
>  	 * If the port is in the middle of closing, bail out now.
>  	 */
>  	if (tty_hung_up_p(filp) || (info->flags & UIF_CLOSING)) {
> +		up(&port_sem);
>  	    	wait_event_interruptible(info->open_wait,
>  					 !(info->flags & UIF_CLOSING));
>  		retval = (info->port->flags & UPF_HUP_NOTIFY) ?
> @@ -1571,20 +1657,16 @@
>  	}
>
>  	/*
> -	 * Start up the serial port.  We have this semaphore here to
> -	 * prevent uart_startup or uart_shutdown being re-entered if
> -	 * we sleep while requesting an IRQ.
> +	 * Start up the serial port.
>  	 */
> -	down(&port_sem);
>  	retval = uart_startup(info, 0);
> -	up(&port_sem);
> -	if (retval)
> -		goto fail;
>
>  	/*
> -	 * Wait until the port is ready.
> +	 * If we succeeded, wait until the port is ready.
>  	 */
> -	retval = uart_block_til_ready(filp, info);
> +	if (retval == 0)
> +		retval = uart_block_til_ready(filp, info);
> +	up(&port_sem);
>
>  	/*
>  	 * If this is the first open to succeed, adjust things to suit.