Re: [PATCH] C99 designated initializers for drivers/scsi

Arnaldo Carvalho de Melo
2002-10-12T17:37:04Z

Em Sat, Oct 12, 2002 at 11:59:01AM -0500, Art Haas escreveu:
>
> Art Haas
>
> --- linux-2.5.42/drivers/scsi/ide-scsi.c.old 2002-10-12 09:46:55.000000000 -0500
> +++ linux-2.5.42/drivers/scsi/ide-scsi.c 2002-10-12 09:51:32.000000000 -0500
> @@ -574,29 +574,29 @@
> * IDE subdriver functions, registered with ide.c
> */
> static ide_driver_t idescsi_driver = {
> + .busy = 0,
> + .supports_dsc_overlap = 0,
> + .standby = NULL,
> + .flushcache = NULL,
> + .media_change = NULL,
> + .revalidate = NULL,
> + .pre_reset = NULL,
> + .capacity = NULL,
> + .special = NULL,
> + .proc = NULL,

Art, I suggest that you simply delete the lines that initializes to 0 or NULL,
as the compiler will take care of zeroing it and the source code gets a bit
smaller.

- Arnaldo