public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Barry K. Nathan" <barryn@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] pl2303 oops in 2.4.20-pre10 (and 2.5 too)
Date: Sat, 12 Oct 2002 17:49:39 -0700	[thread overview]
Message-ID: <20021013004938.GF12469@kroah.com> (raw)
In-Reply-To: <20021012205604.GB17162@ip68-4-86-174.oc.oc.cox.net>

On Sat, Oct 12, 2002 at 01:56:04PM -0700, Barry K. Nathan wrote:
> The following patch (which reverts part of 2.4.20-pre2) seems to fix my
> pl2303 oopsing (and let me use the device properly again) in 2.4.20-pre2
> through -pre5. This patch doesn't work with -pre6 or up though (due to
> white space differences and, more importantly, the removal of all 6
> variables referenced in the if-statement).
> 
> Anyway, I'm posting this in case it provides another clue as to what's
> not working.

Ah, thanks for finding this.  Yes this does help, a bit.  Hm.  What /dev
device are you trying to write to, ttyUSB0 or ttyUSB1?  Yeah, I think we
need this kind of check back in to fix this problem, but I don't see off
the top of my head how to add it back...

And yes, the problem in 2.5 where you see the device register itself
twice is a known bug (to me at least), it goes away if you disable
CONFIG_USB_SERIAL_GENERIC.  It's on my TODO list, which seems to be
getting longer every day...

Any suggestions on how to fix this are appreciated.  Basically we don't
want to claim the interface that only has the interrupt endpoint on it
for this device, as we kinda already did in the section entitled END
HORRIBLE HACK FOR PL2303.  I guess we could just mark that interface as
claimed already, and then probe() would not get called again.  Want to
throw a call to usb_driver_claim_interface() into that section, grabbing
that interface, and see if that works?

thanks,

greg k-h

  parent reply	other threads:[~2002-10-13  0:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-09 23:36 [BUG] pl2303 oops in 2.4.20-pre10 (and 2.5 too) Barry K. Nathan
2002-10-09 23:53 ` Greg KH
2002-10-11  2:39   ` Barry K. Nathan
     [not found]     ` <20021011170623.GB4123@kroah.com>
2002-10-12  6:30       ` Barry K. Nathan
2002-10-12 20:56         ` Barry K. Nathan
2002-10-13  0:42           ` [PATCH] 2.4.20-pre10: make PL-2303 hack work again Barry K. Nathan
2002-10-13  1:16             ` Greg KH
2002-10-13  1:54               ` Barry K. Nathan
2002-10-13  4:30               ` [PATCH/RFC] 2.5.42 partial fix for older pl2303 Barry K. Nathan
2002-10-13 20:25                 ` Greg KH
2002-10-14  2:49                   ` Barry K. Nathan
2002-10-14  4:17                     ` Barry K. Nathan
2002-10-15  5:52                       ` Greg KH
2002-10-13  0:49           ` Greg KH [this message]
2002-10-13  1:26             ` [BUG] pl2303 oops in 2.4.20-pre10 (and 2.5 too) Barry K. Nathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021013004938.GF12469@kroah.com \
    --to=greg@kroah.com \
    --cc=barryn@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox