From: Pavel Machek <pavel@suse.cz>
To: Rik van Riel <riel@conectiva.com.br>
Cc: Hu Gang <hugang@soulinfo.com>, linux-kernel@vger.kernel.org
Subject: Re: patch for 2.5.42. 2/2
Date: Mon, 14 Oct 2002 18:52:02 +0200 [thread overview]
Message-ID: <20021014185202.C585@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44L.0210130133070.22735-100000@imladris.surriel.com>
Hi!
> > --- linux-2.5.42/drivers/net/3c59x.c Sat Oct 12 21:25:00 2002
> > +++ linux-2.5.42-suspend/drivers/net/3c59x.c Sat Oct 12 21:20:48 2002
>
> > +#ifdef CONFIG_PM
> > + int in_suspend;
> > +#endif
>
> This looks like a serious design mistake. Surely it would be
> better to just have the network layer stop operations when the
> system is going into suspend, instead of having to modify 100
> individual network drivers ?
Whole userland is stopped at that point. That should mean that new
requests can not come.
OTOH packet from the network *can* come, and higher levels can not do
much with that. [They could ifconfig down the network interface... But
that can have sideefects we don't want to see...]
Pavel
--
When do you have heart between your knees?
next prev parent reply other threads:[~2002-10-15 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-13 3:20 patch for 2.5.42. 2/2 Hu Gang
2002-10-13 3:34 ` Rik van Riel
2002-10-13 3:33 ` Hu Gang
2002-10-14 16:52 ` Pavel Machek [this message]
2002-10-15 14:10 ` Rik van Riel
2002-10-15 20:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021014185202.C585@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=hugang@soulinfo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox