public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Adam Belay <ambx1@neo.rr.com>, Jaroslav Kysela <perex@perex.cz>,
	torvalds@transmeta.com, alan@lxorguk.ukuu.org.uk,
	jdthood@yahoo.co.uk, boissiere@nl.linux.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PnP Layer Rewrite V0.7 - 2.4.42
Date: Mon, 14 Oct 2002 20:13:12 -0700	[thread overview]
Message-ID: <20021015031312.GB10756@kroah.com> (raw)
In-Reply-To: <20021014214334.GA315@neo.rr.com>

On Mon, Oct 14, 2002 at 09:43:34PM +0000, Adam Belay wrote:
>  #ifdef CONFIG_PROC_FS
> -	/*isapnp_proc_init();*/
> +	isapnp_proc_init();
>  #endif


Please bury the #ifdef in the .h file, it shouldn't be in the .c file.

thanks,

greg k-h

  reply	other threads:[~2002-10-15  3:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20021014135452.GB444@neo.rr.com>
2002-10-14 18:10 ` [PATCH] PnP Layer Rewrite V0.7 - 2.4.42 Greg KH
2002-10-15 16:09   ` Adam Belay
2002-10-15 20:32     ` Greg KH
2002-10-14 19:10 ` Jaroslav Kysela
2002-10-14 19:22   ` Jeff Garzik
2002-10-14 21:43   ` Adam Belay
2002-10-15  3:13     ` Greg KH [this message]
2002-10-15 15:36 ` Thomas Hood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021015031312.GB10756@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ambx1@neo.rr.com \
    --cc=boissiere@nl.linux.org \
    --cc=jdthood@yahoo.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox