From: Benjamin LaHaise <bcrl@redhat.com>
To: John Myers <jgmyers@netscape.com>
Cc: linux-aio@kvack.org, linux-kernel@vger.kernel.org,
torvalds@transmeta.com
Subject: Re: [PATCH] aio updates
Date: Tue, 15 Oct 2002 15:57:38 -0400 [thread overview]
Message-ID: <20021015155738.B16156@redhat.com> (raw)
In-Reply-To: <200210150117.g9F1HXm26163@msglinux1.mcom.com>; from jgmyers@netscape.com on Mon, Oct 14, 2002 at 06:17:33PM -0700
On Mon, Oct 14, 2002 at 06:17:33PM -0700, John Myers wrote:
> Please apply.
> # fix uninitialized variable causing incorrect timeout
> # add support for IO_CMD_NOOP
> # make sys_io_cancel(), not cancel method, initialize most of returned result
> # minor aio_cancel_all() optimization
> # fix a debug printk
I've applied most of this to my tree, except for the NOOP bits. My
concern is that the way you've implemented NOOP does not allow for all
possible return codes to be passed in due to the error checking the
iocb submit code performs on the inputs. It can also spuriously fail
if the filedescriptor field points to an fd that doesn't exist, which
could be somewhat unexpected (especially if it is initialized to 0 by
default, and therefore would not fail during normal operation where a
program is run with stdin). Got any idea for cleaning those problems
up?
-ben
next prev parent reply other threads:[~2002-10-15 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-15 1:17 [PATCH] aio updates John Myers
2002-10-15 19:57 ` Benjamin LaHaise [this message]
2002-10-15 20:50 ` John Gardiner Myers
2002-10-15 21:31 ` Benjamin LaHaise
2002-10-15 22:05 ` John Gardiner Myers
2002-10-15 22:08 ` John Gardiner Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021015155738.B16156@redhat.com \
--to=bcrl@redhat.com \
--cc=jgmyers@netscape.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox