From: Andreas Dilger <adilger@clusterfs.com>
To: Christoph Hellwig <hch@infradead.org>,
"Theodore Ts'o" <tytso@mit.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Add extended attributes to ext2/3
Date: Tue, 15 Oct 2002 10:21:19 -0600 [thread overview]
Message-ID: <20021015162119.GF15552@clusterfs.com> (raw)
In-Reply-To: <20021015171606.A29069@infradead.org>
On Oct 15, 2002 17:16 +0100, Christoph Hellwig wrote:
> On Tue, Oct 15, 2002 at 10:04:17AM -0600, Andreas Dilger wrote:
> > > - mb_cache_lock();
> > > + spin_lock(&mb_cache_spinlock);
> > > l = mb_cache_lru_list.prev;
> > > while (l != &mb_cache_lru_list) {
> > > struct mb_cache_entry *ce =
> > > list_entry(l, struct mb_cache_entry, e_lru_list);
> >
> > Couldn't these all be "list_for_each{_safe}"?
>
> They'd have to be list_for_each_safe_prev, which is not currently
> in list.h. The EVMS folks have a patch to add it, though..
Is there a reason why the code can't just add items into the list in
the reverse order (i.e. list_add_tail()) and then walk in the normal
direction via list_for_each_safe()?
Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/
next prev parent reply other threads:[~2002-10-15 16:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-15 3:33 [PATCH 1/4] Add extended attributes to ext2/3 tytso
2002-10-15 4:46 ` Andrew Morton
2002-10-15 5:04 ` Theodore Ts'o
2002-10-15 5:31 ` Andreas Dilger
2002-10-15 13:05 ` Theodore Ts'o
2002-10-15 10:26 ` Olaf Dietsche
2002-10-15 11:58 ` Christoph Hellwig
2002-10-15 13:15 ` Theodore Ts'o
2002-10-15 15:25 ` Christoph Hellwig
2002-10-15 15:31 ` Christoph Hellwig
2002-10-15 16:04 ` Andreas Dilger
2002-10-15 16:16 ` Christoph Hellwig
2002-10-15 16:21 ` Andreas Dilger [this message]
2002-10-15 16:43 ` Andreas Gruenbacher
2002-10-15 16:41 ` Theodore Ts'o
2002-10-15 16:59 ` Christoph Hellwig
2002-10-15 15:33 ` Christoph Hellwig
2002-10-15 15:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021015162119.GF15552@clusterfs.com \
--to=adilger@clusterfs.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox