public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Levon <levon@movementarian.org>
To: Andi Kleen <ak@muc.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [4/7] oprofile - NMI hook
Date: Wed, 16 Oct 2002 00:01:06 +0100	[thread overview]
Message-ID: <20021015230106.GA43030@compsoc.man.ac.uk> (raw)
In-Reply-To: <m33cr7l3ab.fsf@averell.firstfloor.org>

On Wed, Oct 16, 2002 at 12:56:28AM +0200, Andi Kleen wrote:

> > This patch provides a simple api to let oprofile hook into
> > the NMI interrupt for the perfctr profiler.
> 
> I would suggest using a notifier list instead (include/linux/notifier.h) 
> This would handle multiple users cleanly.

How ? The only safe way I can see would be to spin lock around the NMI
(and try lock when an NMI arrives).  This would either make every NMI
contend on a single spinlock, or require a NR_CPUS-sized array of
spinlocks, which is just ugly. And that wouldn't solve the
power-management problem - any NMI users need to collaborate to disable
NMI generation on a suspend.

regards
john

-- 
"CUT IT OUT FACEHEAD"
	- jeffk

  reply	other threads:[~2002-10-15 23:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-15 22:33 [PATCH] [4/7] oprofile - NMI hook John Levon
2002-10-15 22:56 ` Andi Kleen
2002-10-15 23:01   ` John Levon [this message]
2002-10-15 23:18     ` Andi Kleen
2002-10-16 14:06 ` Keith Owens
2002-10-16 16:36   ` John Levon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021015230106.GA43030@compsoc.man.ac.uk \
    --to=levon@movementarian.org \
    --cc=ak@muc.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox