From: Greg KH <greg@kroah.com>
To: joe perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, linux-security-module@wirex.com
Subject: Re: [RFC] change format of LSM hooks
Date: Wed, 16 Oct 2002 16:46:53 -0700 [thread overview]
Message-ID: <20021016234653.GA27285@kroah.com> (raw)
In-Reply-To: <1034786033.9520.8.camel@localhost.localdomain>
On Wed, Oct 16, 2002 at 12:33:50PM -0400, joe perches wrote:
> On Wed, 2002-10-16 at 14:59, Greg KH wrote:
>
> I think something like:
>
> #define check_security(type,args...) security_##type(##args)
>
> would be cleaner and would prefer not collapsing the
>
> ret = check_security()
> if (ret)
>
> function use
No, I have to collapse the if and assign lines in order to take
advantage of the compiler when CONFIG_SERIAL=n. Then anything within
the if {} will just be compiled away if the return value of a static
inline function is 0.
As for using a macro, that doesn't really have any advantages over the
existing different functions.
thanks,
greg k-h
next prev parent reply other threads:[~2002-10-16 23:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20021015194545.GC15864@kroah.com>
[not found] ` <20021015.124502.130514745.davem@redhat.com>
[not found] ` <20021015201209.GE15864@kroah.com>
[not found] ` <20021015.131037.96602290.davem@redhat.com>
[not found] ` <20021015202828.GG15864@kroah.com>
2002-10-16 0:07 ` [RFC] change format of LSM hooks Greg KH
2002-10-16 0:03 ` David S. Miller
2002-10-16 8:15 ` Greg KH
2002-10-16 18:59 ` Greg KH
2002-10-16 16:33 ` joe perches
2002-10-16 23:46 ` Greg KH [this message]
2002-10-16 23:56 ` David S. Miller
2002-10-16 19:07 ` Greg KH
2002-10-17 1:41 ` Rusty Russell
2002-10-17 3:33 ` Daniel Phillips
2002-10-17 13:21 ` Christoph Hellwig
2002-10-17 16:55 ` Greg KH
2002-10-17 7:41 Rusty Russell
2002-10-17 17:20 ` [RFC] change format of LSM hooks Daniel Phillips
2002-10-18 2:04 ` Rusty Russell
2002-10-17 17:25 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021016234653.GA27285@kroah.com \
--to=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@wirex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox