From: Christoph Hellwig <hch@infradead.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Module loader preparation
Date: Thu, 17 Oct 2002 14:33:08 +0100 [thread overview]
Message-ID: <20021017143308.A24271@infradead.org> (raw)
In-Reply-To: <20021017034634.8D6462C0EB@lists.samba.org>; from rusty@rustcorp.com.au on Thu, Oct 17, 2002 at 01:31:54PM +1000
On Thu, Oct 17, 2002 at 01:31:54PM +1000, Rusty Russell wrote:
> This patch fixes a couple of places using the old "I can just call my
> function init_module() and it will be called at module init" and a
> couple of modules without module_init() declarations.
>
> These uses are obsolete with the in-kernel module loader, because the
> module_init() is where we put the module name in the ".modulename"
> section (we could have a "no_init_func()" thing, but it's fairly rare
> and hardly intuitive).
I don't think requiring a init func is a good idea. Please fix
your module loader to generate a stub if no module_init() is
present instead.
init_module() sounds like a good idea to me, though.
next prev parent reply other threads:[~2002-10-17 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 3:31 [PATCH] Module loader preparation Rusty Russell
2002-10-17 13:33 ` Christoph Hellwig [this message]
2002-10-18 1:39 ` Rusty Russell
2002-10-17 16:02 ` Kai Germaschewski
2002-10-18 2:55 ` Rusty Russell
2002-10-18 21:52 ` Kai Germaschewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021017143308.A24271@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox