From: Dave Jones <davej@codemonkey.org.uk>
To: Robin Holt <holt@sgi.com>
Cc: Dave Jones <davej@codemonkey.org.uk>,
John Hesterberg <jh@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.43 CSA, Job, and PAGG
Date: Thu, 17 Oct 2002 19:52:27 +0100 [thread overview]
Message-ID: <20021017185227.GA3267@suse.de> (raw)
In-Reply-To: <Pine.SGI.4.33.0210171249500.23137-100000@fsgi123.americas.sgi.com>
On Thu, Oct 17, 2002 at 12:50:52PM -0500, Robin Holt wrote:
> > The first two lines in the csa patch contain an obvious jiffy-wrap bug.
>
> Fixed. The patch file named above is now a link to
> linux-2.5.43_002-csa.patch. The old file is linux-2.5.43_001-csa.patch
>
> If you could re-review, I would appreciate it.
Casting it to a ulong won't help you.
Imagine jiffies begins at 0xffffffff
unsigned long start_wait = jiffies;
...
current->bwtime += (unsigned long) jiffies - start_wait;
and when you read it the second time, it's rolled over to 0x00000001
You now increment bwtime by $BIGNUM
--
| Dave Jones. http://www.codemonkey.org.uk
next prev parent reply other threads:[~2002-10-17 18:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 15:21 [PATCH] 2.5.43 CSA, Job, and PAGG John Hesterberg
2002-10-17 16:21 ` Dave Jones
2002-10-17 17:50 ` Robin Holt
2002-10-17 18:52 ` Dave Jones [this message]
2002-10-18 2:33 ` Christoph Hellwig
2002-10-18 19:05 ` John Hesterberg
2002-10-21 19:43 ` Christoph Hellwig
2002-10-18 2:44 ` Christoph Hellwig
2002-10-18 1:07 ` Andi Kleen
2002-10-18 1:22 ` Robin Holt
2002-10-18 14:37 ` Keith Owens
2002-10-18 22:00 ` Christoph Hellwig
2002-10-18 15:43 ` Keith Owens
2002-10-18 16:19 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021017185227.GA3267@suse.de \
--to=davej@codemonkey.org.uk \
--cc=holt@sgi.com \
--cc=jh@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox