From: Andreas Dilger <adilger@clusterfs.com>
To: Peter Chubb <peter@chubb.wattle.id.au>
Cc: Benjamin LaHaise <bcrl@redhat.com>, Andi Kleen <ak@muc.de>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] statfs64 no longer missing
Date: Fri, 18 Oct 2002 00:17:01 -0600 [thread overview]
Message-ID: <20021018061701.GA18925@clusterfs.com> (raw)
In-Reply-To: <15791.21383.361727.533851@wombat.chubb.wattle.id.au>
On Oct 18, 2002 10:19 +1000, Peter Chubb wrote:
> -int fat_statfs(struct super_block *sb,struct statfs *buf)
> +int fat_statfs(struct super_block *sb, struct kstatfs *buf)
> {
> int free,nr;
>
> if (MSDOS_SB(sb)->cvf_format &&
> MSDOS_SB(sb)->cvf_format->cvf_statfs)
> return MSDOS_SB(sb)->cvf_format->cvf_statfs(sb,buf,
> - sizeof(struct statfs));
> + sizeof(struct kstatfs));
How about
return MSDOS_SB(sb)->cvf_format->cvf_statfs(sb, buf,
sizeof(*buf));
> +struct statfs64 {
> + long f_type;
> + long f_bsize;
> + long long f_blocks;
> + long long f_bfree;
> + long long f_bavail;
> + long long f_files;
> + long long f_ffree;
> + __kernel_fsid_t f_fsid;
> + long f_namelen;
> + long f_frsize;
> + long f_spare[5];
> };
Wasn't Dave Miller just saying that passing "long" between user-space
and the kernel is just a bad idea? Should we use "__u32" and "__u64"
here instead?
Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/
next prev parent reply other threads:[~2002-10-18 6:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-16 14:06 statfs64 missing Andi Kleen
2002-10-16 14:16 ` Trond Myklebust
[not found] ` <15789.64263.606518.921166@wombat.chubb.wattle.id.au>
2002-10-17 0:01 ` Andi Kleen
2002-10-17 19:41 ` Benjamin LaHaise
2002-10-18 0:19 ` [PATCH] statfs64 no longer missing Peter Chubb
2002-10-18 0:26 ` Benjamin LaHaise
2002-10-18 2:31 ` Andi Kleen
2002-10-18 3:27 ` Peter Chubb
2002-10-18 6:17 ` Andreas Dilger [this message]
2002-10-18 6:31 ` Andi Kleen
2002-10-18 6:41 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021018061701.GA18925@clusterfs.com \
--to=adilger@clusterfs.com \
--cc=ak@muc.de \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@chubb.wattle.id.au \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox