public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: acme@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv4: only produce one record in fib_seq_show
Date: Sat, 19 Oct 2002 16:54:51 -0700 (PDT)	[thread overview]
Message-ID: <20021019.165451.110952098.davem@redhat.com> (raw)
In-Reply-To: <20021019233236.GI14009@conectiva.com.br>


This change is problematic, the FIB etc. lookup engine internal
structure must be entirely private to the implementation.

That allows it to be changed arbitrarily and the rest of the
kernel will not notice.

You should probably move the seq_file handling here directly back into
the routing code.

Really, we should not be exporting all of these lookup tables merely
for the sake of ip_proc.c, in fact move all this seq_file stuff back
into the arp/udp/fib/etc. places they came from.  Exporting these
tables just for this makes no sense the more I think about it.

  reply	other threads:[~2002-10-19 23:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-19 23:32 [PATCH] ipv4: only produce one record in fib_seq_show Arnaldo Carvalho de Melo
2002-10-19 23:54 ` David S. Miller [this message]
2002-10-20  0:09   ` Arnaldo Carvalho de Melo
2002-10-20  0:38     ` David S. Miller
2002-10-20  1:03       ` Arnaldo Carvalho de Melo
2002-10-20  4:13         ` David S. Miller
2002-10-20  5:08           ` Arnaldo Carvalho de Melo
2002-10-20  5:14             ` David S. Miller
2002-10-20  5:26               ` Arnaldo Carvalho de Melo
2002-10-20  5:52               ` Andrew Morton
2002-10-20  5:15             ` David S. Miller
2002-10-20  5:30               ` Arnaldo Carvalho de Melo
2002-10-20  7:08             ` Keith Owens
     [not found] <20021020010331.GB15254@conectiva.com.br.suse.lists.linux.kernel>
     [not found] ` <20021019.211307.00017347.davem@redhat.com.suse.lists.linux.kernel>
     [not found]   ` <20021020050849.GD15254@conectiva.com.br.suse.lists.linux.kernel>
     [not found]     ` <20021019.221403.116117803.davem@redhat.com.suse.lists.linux.kernel>
2002-10-20  5:58       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021019.165451.110952098.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=acme@conectiva.com.br \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox