From: Andries Brouwer <aebr@win.tue.nl>
To: Christoph Hellwig <hch@infradead.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Jan Kasprzak <kas@informatics.muni.cz>,
linux-kernel@vger.kernel.org
Subject: Re: 2.4.20-pre11 /proc/partitions read
Date: Tue, 22 Oct 2002 21:58:07 +0200 [thread overview]
Message-ID: <20021022195807.GA26620@win.tue.nl> (raw)
In-Reply-To: <20021022203504.A7770@infradead.org>
On Tue, Oct 22, 2002 at 08:35:04PM +0100, Christoph Hellwig wrote:
> Both of those should be fixed by my patch, i.e. were caused by a bug
> in fpos handling in the seq_file /proc/partitions. There is nothing
> about the statistics in them.
True. I quoted these references (i) because they are readily available,
and (ii) because they show problems with the file changing contents while
it is being read.
These two references predate your 2.4.19 patch - they are about a
Redhat-private kernel that already had these disk statistics.
The default 1K buffer was not large enough. Some utilities have now
been patched to tell stdio to use a 16K buffer. We won't have to wait
long before also that will turn out to be insufficient.
It is bad that one has to patch mount and the ext2 utilities and fdisk
and I don't know what other programs because some irrelevant (to mount etc.)
and changing stuff was added to /proc/partitions.
Andries
next prev parent reply other threads:[~2002-10-22 19:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-22 14:19 2.4.20-pre11 /proc/partitions read Jan Kasprzak
2002-10-22 15:10 ` Richard B. Johnson
2002-10-22 16:14 ` Jan Kasprzak
2002-10-22 18:40 ` Andries Brouwer
2002-10-22 18:10 ` Marcelo Tosatti
2002-10-23 8:36 ` Jan Kasprzak
2002-10-22 18:45 ` Christoph Hellwig
2002-10-22 18:59 ` Andries Brouwer
2002-10-22 18:26 ` Marcelo Tosatti
2002-10-22 19:32 ` Andries Brouwer
2002-10-22 19:35 ` Christoph Hellwig
2002-10-22 19:58 ` Andries Brouwer [this message]
2002-10-22 20:32 ` Alan Cox
2002-10-23 8:39 ` Jan Kasprzak
2002-10-23 9:13 ` Jan Kasprzak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021022195807.GA26620@win.tue.nl \
--to=aebr@win.tue.nl \
--cc=hch@infradead.org \
--cc=kas@informatics.muni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox