From: Matthew Wilcox <willy@debian.org>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com
Subject: [PATCH] use 1ULL instead of 1UL in kernel/signal.c
Date: Tue, 22 Oct 2002 22:27:19 +0100 [thread overview]
Message-ID: <20021022222719.H27461@parcelfarce.linux.theplanet.co.uk> (raw)
On PA-RISC we have 36 signals defined for hpux compatibility. So M()
and T() in kernel/signal.c try to do (1UL << 33) which is garbage on 32-bit
architectures. How do people feel about this patch?
--- kernel/signal.c 21 Oct 2002 03:46:14 -0000 1.5
+++ kernel/signal.c 22 Oct 2002 21:25:29 -0000
@@ -96,7 +96,7 @@ int max_queued_signals = 1024;
#define M_SIGEMT 0
#endif
-#define M(sig) (1UL << (sig))
+#define M(sig) (1ULL << (sig))
#define SIG_USER_SPECIFIC_MASK (\
M(SIGILL) | M(SIGTRAP) | M(SIGABRT) | M(SIGBUS) | \
@@ -132,7 +132,7 @@ int max_queued_signals = 1024;
M(SIGXCPU) | M(SIGXFSZ) | M_SIGEMT )
#define T(sig, mask) \
- ((1UL << (sig)) & mask)
+ ((1ULL << (sig)) & mask)
#define sig_user_specific(sig) \
(((sig) < SIGRTMIN) && T(sig, SIG_USER_SPECIFIC_MASK))
(patch copied & pasted; whitespace is munged. This is an indication I
expect to get some pushback on this issue ;-)
--
Revolutions do not require corporate support.
next reply other threads:[~2002-10-22 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-22 21:27 Matthew Wilcox [this message]
2002-10-22 21:57 ` [PATCH] use 1ULL instead of 1UL in kernel/signal.c Alan Cox
2002-10-22 21:48 ` Matthew Wilcox
2002-10-22 23:17 ` Alan Cox
2002-10-23 13:17 ` Matthew Wilcox
2002-10-23 13:48 ` Alan Cox
2002-10-23 13:37 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021022222719.H27461@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox