Re: [PATCH] use 1ULL instead of 1UL in kernel/signal.c

Alan Cox
2002-10-22T22:54:48Z

On Tue, 2002-10-22 at 22:48, Matthew Wilcox wrote:
> On Tue, Oct 22, 2002 at 10:57:59PM +0100, Alan Cox wrote:
> > On Tue, 2002-10-22 at 22:27, Matthew Wilcox wrote:
> > >
> > > On PA-RISC we have 36 signals defined for hpux compatibility. So M()
> > > and T() in kernel/signal.c try to do (1UL << 33) which is garbage on 32-bit
> > > architectures. How do people feel about this patch?
> >
> > How does the compiler output look ?
>
> uhh.. 200 bytes extra on x86 ;-(
>
> -rw-r--r-- 1 willy users 17956 Oct 22 14:44 kernel/signal.o
> -rw-r--r-- 1 willy users 17748 Oct 22 06:50 kernel/signal.o_orig

Care to move the define into include/asm-foo then ?