From: Russell King <rmk@arm.linux.org.uk>
To: Armin Schindler <mac@melware.de>
Cc: Kai Germaschewski <kai-germaschewski@uiowa.edu>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: module_init in interrupt context ?
Date: Fri, 25 Oct 2002 10:04:46 +0100 [thread overview]
Message-ID: <20021025100446.A19910@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.31.0210250806470.24067-100000@phoenix.one.melware.de>; from mac@melware.de on Fri, Oct 25, 2002 at 08:15:05AM +0200
On Fri, Oct 25, 2002 at 08:15:05AM +0200, Armin Schindler wrote:
> > You are never allowed to sleep with a spinlock held, no matter if it's
> > _bh, _irq or just a plain spin_lock(). Doing so creates the possibility of
> > deadlock (assuming your lock actually is necessary and you're not
> > serialized already), current 2.5 btw has debugging code which checks for
> > this bug.
> >
> > So this code was buggy in earlier 2.4 as well, you'll have to create your
> > proc entry outside the protected region or use a semaphore instead of a
> > spinlock.
>
> Okay, I wasn't aware of create_proc_entry() must to be called
> from user-context and outside any locks.
>
> But anyway, isn't the statement "in_interrupt() != 0" somehow wrong
> when just the bh's are disabled ?
You must not schedule with bottom halves disabled.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-10-25 8:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-22 22:07 2.5.44 fs corruption erik
2002-10-23 4:51 ` module_init in interrupt context ? Armin Schindler
2002-10-23 16:13 ` Kai Germaschewski
2002-10-24 16:52 ` Armin Schindler
2002-10-24 17:14 ` Kai Germaschewski
2002-10-25 6:15 ` Armin Schindler
2002-10-25 9:04 ` Russell King [this message]
2002-10-23 10:19 ` 2.5.44 fs corruption Chris Newland
2002-10-23 14:46 ` erik
2002-10-23 15:13 ` Chris Newland
2002-10-23 21:08 ` Jose Luis Domingo Lopez
2002-10-24 3:30 ` erik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021025100446.A19910@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=kai-germaschewski@uiowa.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).